Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability - heap overflow #16

Open
dybrkr opened this issue Nov 5, 2022 · 1 comment
Open

Vulnerability - heap overflow #16

dybrkr opened this issue Nov 5, 2022 · 1 comment

Comments

@dybrkr
Copy link

dybrkr commented Nov 5, 2022

I found it about 4 years ago, and forgot to let know.
still seems like, has vulnerbitity.

  • buffersize (atoi)

https://github.com/avih/miniweb/blob/master/http.c#L2348

  • allocation

phsSocket->bufferSize = phsSocket->request.payloadSize + 1;
phsSocket->request.pucPayload = malloc(phsSocket->bufferSize); // bufferSize

  • memcpy(overflow)

https://github.com/avih/miniweb/blob/master/http.c#L1271 // causes overflow

poc

@avih
Copy link
Owner

avih commented Nov 5, 2022

Thanks.

I'll keep this issue open for posterity, but as the message at the readme and the project page says:

This project is not maintained, and should not be considered secure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants