Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplication of code across webapp and rules-server #47

Open
Tracked by #1385
mahalakshme opened this issue Jun 30, 2023 · 1 comment
Open
Tracked by #1385

Duplication of code across webapp and rules-server #47

mahalakshme opened this issue Jun 30, 2023 · 1 comment

Comments

@mahalakshme
Copy link
Contributor

Case:

  • Both rules-server and webapp use response/request from avni-server. In both cases, to be able to use model functions, we are doing mapping of observations of Subject/Encounter/Enrolment, etc., using mapObservations functions in both code bases. This I think has lead to duplication of code for mapping the observations.

Need:

  • To avoid repeating the fixes in both codebases. I think fix for this made in rules-server might to be repeated in webapp, to get the repeatable question group work in data entry app
  • To have the code in one place

What can be done:

  • Mapping of observations code can be moved to models. Already it is done partially in avni-models using fromObs methods in concept classes.
  • More analysis need to be done to understand why it was not done before
@mahalakshme
Copy link
Contributor Author

explore graalvm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New Issues
Development

No branches or pull requests

1 participant