Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues in retrieving approval status #723

Closed
mahalakshme opened this issue May 3, 2024 · 1 comment
Closed

Issues in retrieving approval status #723

mahalakshme opened this issue May 3, 2024 · 1 comment
Assignees
@himeshr

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented May 3, 2024 •
edited by himeshr
Loading

Issue:

Some ACs here not met

  • When entityType not passed fails like shown below:
api_issue
  • API here is incorrect
    - URL mentioned incorrect,
    - example of entityTypeId incorrect
    - mention the allowed values for entityType

AC:

Fix the above
@mahalakshme mahalakshme changed the title Issues in external APIs Issues in retrieving approval status May 3, 2024
@himeshr himeshr self-assigned this May 3, 2024
himeshr added a commit that referenced this issue May 3, 2024
@himeshr
#723 | Handle null or invalid entityType value for "/api/approvalStat…
e61088d 
…uses"
@himeshr
Copy link
Contributor

himeshr commented May 3, 2024 •
edited
Loading

Dev testing screenshots:
Screenshot 2024-05-03 at 3 25 36 PM
Screenshot 2024-05-03 at 3 27 26 PM

@siddhant3030 siddhant3030 mentioned this issue May 6, 2024
Closed
petmongrels added a commit that referenced this issue May 6, 2024
@petmongrels
#723 - minor text change
16c9f9d
@mahalakshme mahalakshme mentioned this issue May 13, 2024
Closed
himeshr added a commit that referenced this issue May 15, 2024
@himeshr
#723 | Handle null or invalid entityType value for "/api/approvalStat…
023c9f2 
…uses"

(cherry picked from commit e61088d)
himeshr pushed a commit that referenced this issue May 15, 2024
@petmongrels @himeshr
#723 - minor text change
38a36c1 
(cherry picked from commit 16c9f9d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@himeshr himeshr

Labels
None yet
Projects
Avni Product
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vinayvenu @mahalakshme @himeshr