Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to close Rule Failure issue #1059

Closed
Gojo-Taqi opened this issue Oct 10, 2023 · 2 comments
Closed

Unable to close Rule Failure issue #1059

Gojo-Taqi opened this issue Oct 10, 2023 · 2 comments
Assignees
@ashusvnath

Comments

@Gojo-Taqi
Copy link

Gojo-Taqi commented Oct 10, 2023 •
edited by mahalakshme
Loading

Describe the bug

  1. The "Open", "Closed" and "All" buttons get doubled on selecting something.
  2. Not able to close errors.

To Reproduce
Have an obvious JS rule error( I found out when I was trying out a visitSchedueLogic in the client and synced my device to see if I was getting any errors)
Image

Acceptance criteria

  • For the 1st issue above, buttons should not be doubled on selection.
  • For the 2nd issue, add Update dropdown on the top like that of below image - Options should be Open and Closed. And the placeholder text should be "UPDATE"
    Image
@mahalakshme mahalakshme added the bug Something isn't working label Oct 18, 2023
@mahalakshme mahalakshme changed the title Rule failure telemetry issues Unable to close Rule Failure issue Nov 6, 2023
@ashusvnath ashusvnath self-assigned this Nov 8, 2023
ashusvnath pushed a commit that referenced this issue Nov 9, 2023
#1059 | Use explicit name instead of icon for action comparison
96c587f
@mahalakshme
Copy link
Contributor

@ashusvnath can you add a screenshot of current UI now here?

ashusvnath pushed a commit that referenced this issue Nov 17, 2023
#1059 | Fix typo when rendering closedDateTime for a rule failure
35efcc8
@ashusvnath
Copy link

@AchalaBelokar , @mahalakshme : i've fixed the Issue closed date time bug as part of this card

@mahalakshme mahalakshme removed the bug Something isn't working label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashusvnath ashusvnath

Labels
None yet
Projects
Avni Product
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vinayvenu @ashusvnath @mahalakshme @Gojo-Taqi