Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect snackbar color when profile picture URL incorrect #1199

Closed
Tracked by #1557
mahalakshme opened this issue Apr 17, 2024 · 4 comments · Fixed by #1201
Closed
Tracked by #1557

Incorrect snackbar color when profile picture URL incorrect #1199

mahalakshme opened this issue Apr 17, 2024 · 4 comments · Fixed by #1201
Assignees
@ombhardwajj
Labels
good first issue Good for newcomers

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Apr 17, 2024 •
edited
Loading

Steps to reproduce:

  • Add a profile picture for an individual
  • In the db remove 'https://' from the profile picture
  • Open the individual in data entry app.

AC:

Update the toast color to red thats already used for error scenarios in our code base.

Screenshot 2024-04-17 at 12 21 17 PM
@mahalakshme mahalakshme added the good first issue Good for newcomers label Apr 17, 2024
@mahalakshme mahalakshme mentioned this issue Apr 17, 2024
Open
ombhardwajj added a commit to ombhardwajj/avni-webapp that referenced this issue Apr 17, 2024
@ombhardwajj
avniproject#1199|Snackbar color corrected((changed to red) when prof…
0ef631a 
…ile picture URL incorrect
ombhardwajj added a commit to ombhardwajj/avni-webapp that referenced this issue Apr 17, 2024
@ombhardwajj
avniproject#1199|Snackbar color corrected(changed to red) when profi…
45bbd77 
…le picture URL incorrect
@ombhardwajj ombhardwajj mentioned this issue Apr 17, 2024
Merged
@ombhardwajj
Copy link
Contributor

@mahalakshme , I have fixed this issue and created a PR! Please have a look!

vinayvenu added a commit that referenced this issue Apr 17, 2024
@vinayvenu
Merge pull request #1201 from ombhardwajj/snackbarcolorfix
c3cac9a 
 #1199 | Snackbar color corrected(changed to red) when profile picture URL incorrect
@vinayvenu vinayvenu reopened this Apr 17, 2024
@replyre
Copy link

replyre commented Apr 24, 2024

hello :)
Is this issue open?

@vinayvenu
Copy link
Member

@replyre no. There has already been a merge against this issue. It will be closed once QA is done.

@replyre
Copy link

replyre commented Apr 24, 2024

ok, do let me know if there tasks in which I can help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ombhardwajj ombhardwajj

Labels
good first issue Good for newcomers
Projects
Avni Product
Archived in project
Milestone
No milestone
4 participants
@vinayvenu @mahalakshme @ombhardwajj @replyre