Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues arising when creating concepts inline within a form not handled #1292

Closed
mahalakshme opened this issue Jul 23, 2024 · 1 comment
Closed
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Jul 23, 2024

Issues:

  • Issue 1: Try creating a concept with same name inline in the form. Shows stacktrace like in the image below. Instead under concept name show the error message 'Concept with same name already exists.'
  • Issue 2: Dont enter data type. It doesn't show any error message - Need to show 'Required' at least like in Concepts page.

Image

Some cases like low absolute needing to be lower than high absolute for numeric concepts works on inline concept creation as well. And the need to enter subject type for subject concepts, etc., are handled.

Technical:

  • There is code duplication between CreateEditConcept.js and FormDesignerHandlers.js. So not everything in CreateEditConcept.js in handled in FormDesignerHandlers.js. This seems to be the issue. If possible try to handle/validate them at one place.
@mahalakshme mahalakshme changed the title Creating concept with same name from a form not handled Issues arising when creating concepts inline within a form not handled Aug 5, 2024
@himeshr himeshr self-assigned this Aug 23, 2024
himeshr added a commit that referenced this issue Aug 23, 2024
himeshr added a commit to avniproject/avni-server that referenced this issue Aug 23, 2024
himeshr added a commit that referenced this issue Aug 23, 2024
@himeshr
Copy link
Contributor

himeshr commented Aug 23, 2024

For testing, check for issues around the following:

  • Concept create / edit from Concept Screen
  • Inline Concept create during Form Edit
    • concept with same name
    • concept without dataType
    • concept of type Location (User Catchement , lowest and highest address level types)
    • concept of type Number
    • concept of type Subject

Sample screeshot for showing a more user friendly error message:

Screenshot 2024-08-23 at 6 32 07 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants