Issue with upload profile picture

[mahalakshme]

https://avni.freshdesk.com/a/tickets/3776

AC:

• Uploading icons for report cards, subject type, individual profile picture should be possible if the user has corresponding privilege for the entity. ie. 'Edit offline dashboard and report card', 'Edit subject type' and 'Register subject' resp., The same for uploading image when creating a news broadcast
• it should not require 'Edit Organisation Configuration' privilege.

Technical:

It is happening because we have one save upload image endpoint which is used from different places and it should require appropriate privilege.

[mahalakshme]

@petmongrels the second issue( 2. the other issue i noticed was that, in dea after uploading if I go back in the wizard then the image is not shown. ) u had mentioned in the ticket seems to be for the same reason:- it is happening bcoz image upload didnt happen.

or am I missing something?

[petmongrels]

yes it is possible, i didn't check.

…

On Tue, Sep 17, 2024 at 2:51 PM mahalakshme ***@***.***> wrote: @petmongrels <https://github.com/petmongrels> the second issue( 2. the other issue i noticed was that, in dea after uploading if I go back in the wizard then the image is not shown. ) u had mentioned in the ticket seems to be for the same reason:- it is happening bcoz image upload didnt happen. or am I missing something? — Reply to this email directly, view it on GitHub <#1336 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZ3C2NUSCMLZUHC4SOKNTZW7YCBAVCNFSM6AAAAABOEXRV3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJVGAYDGMRXHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Vivek Singh | +91 98452 32929 | @petmongrels <https://twitter.com/petmongrels>

[1t5j0y]

Additional commit: avniproject/avni-server@b9a82de

[1t5j0y]

Changes:

• Refactoring to change incorrectly named API params and variables which referred to 'bucket' when the intent was 'folder'.
• Writes to news entities fixed to require EditNews privilege and not EditOrganisationConfiguration
• Enforced RegisterSubject or EditSubject access check on Subject save from DEA
• Enforced media sub folder level access for uploads via POST /media/saveImage?folderName=
  -- no folderName specified - error condition
  -- folderName is 'icons' - EditSubjectType or EditOfflineDashboardAndReportCard
  -- folderName is 'news' - EditNews
  -- folderName is 'profile-pics' - RegisterSubject or EditSubject (any subject type)
• Fixed transactional entity specific access check to only consider non voided group_privileges