Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visit Scheduling] Should be able to schedule a visit without conditions #1345

Open
Tracked by #1649
mahalakshme opened this issue Sep 20, 2024 · 1 comment
Open
Tracked by #1649

[Visit Scheduling] Should be able to schedule a visit without conditions #1345

mahalakshme opened this issue Sep 20, 2024 · 1 comment
Assignees
@1t5j0y

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Sep 20, 2024 •
edited
Loading

Need:

Currently some condition in visit schedule dragdrop component needs to be mentioned for the rule to get generated. There are workarounds but they are not intuitive.

Screen.Recording.2024-09-20.at.9.46.57.PM.mov

AC:

  • Should be able to schedule a visit from the drag-drop component, without any condition mentioned.
  • If condition is only half-complete then it is fine to show error like currently done.
@mahalakshme mahalakshme mentioned this issue Sep 22, 2024
Open
@1t5j0y 1t5j0y self-assigned this Oct 8, 2024
1t5j0y added a commit to avniproject/rules-config that referenced this issue Oct 9, 2024
@1t5j0y
avniproject/avni-webapp#1345 | Make conditions optional for rules
fce1569
1t5j0y added a commit that referenced this issue Oct 9, 2024
@1t5j0y
#1345 | update rules-config dependency version
fa1a7bd
@1t5j0y
Copy link
Contributor

1t5j0y commented Oct 9, 2024

The change makes having a condition optional for any declarative rule.

1t5j0y added a commit to avniproject/rules-config that referenced this issue Oct 10, 2024
@1t5j0y
avniproject/avni-webapp#1345 | Fix DeclarativeRule.isEmpty logic
c722879
1t5j0y added a commit that referenced this issue Oct 10, 2024
@1t5j0y
#1345 | update rules-config dependency version after fix
db21e8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1t5j0y 1t5j0y

Labels
None yet
Projects
Avni Product
Status: Code Review Ready
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mahalakshme @1t5j0y