Skip to content

Commit

Permalink
perf: Fix false results and add Fedora support
Browse files Browse the repository at this point in the history
Updated perf tests to enable fedora testing

This patch will also enable "perf test" failures
which were earlier cancelled due to missing
"fedora" support in distro.detect()

Signed-off-by: Misbah Anjum N <[email protected]>
  • Loading branch information
misanjumn committed Mar 26, 2024
1 parent 5692719 commit 7ce8827
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion perf/perf_duplicate_probe.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def setUp(self):
if 'Ubuntu' in distro_name:
deps.extend(['linux-tools-common', 'linux-tools-%s' %
platform.uname()[2]])
elif distro_name in ['rhel', 'SuSE']:
elif distro_name in ['rhel', 'SuSE', 'fedora', 'centos']:
deps.extend(['perf'])
else:
self.cancel("Install the package for perf supported\
Expand Down
2 changes: 1 addition & 1 deletion perf/perf_script_bug.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def setUp(self):
parser.read(self.get_data('probe.cfg'))
self.perf_probe = parser.get(detected_distro.name, 'probepoint')
deps = ['gcc', 'make']
if detected_distro.name in ['rhel', 'SuSE']:
if detected_distro.name in ['rhel', 'SuSE', 'fedora', 'centos']:
deps.extend(['perf'])
elif detected_distro.name in ['Ubuntu']:
deps.extend(['linux-tools-common', 'linux-tools-%s' %
Expand Down
2 changes: 2 additions & 0 deletions perf/perf_script_bug.py.data/probe.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ probepoint = 3
probepoint = 3
[Ubuntu]
probepoint = 3
[fedora]
probepoint = 3
4 changes: 3 additions & 1 deletion perf/perf_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,16 @@ def setUp(self):
deps.extend(['perf', 'gcc-c++'])
if 'SuSE' in detected_distro.name:
deps.extend(['kernel-default-debuginfo'])
elif 'fedora' in detected_distro.name:
deps.extend(['clang', 'kernel-debuginfo'])
else:
deps.extend(['clang', 'kernel-debuginfo',
'perf-debuginfo'])
else:
self.cancel("Install the package for perf supported\
by %s" % detected_distro.name)
if run_type == 'upstream':
if 'rhel' in detected_distro.name:
if detected_distro.name in ['rhel', 'fedora']:
deps.extend(['systemtap-sdt-devel', 'slang-devel',
'perl-ExtUtils-Embed', 'libcap-devel',
'numactl-devel', 'libbabeltrace-devel',
Expand Down

0 comments on commit 7ce8827

Please sign in to comment.