Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xfstest fixes with upstream as a target #2778

Merged
merged 4 commits into from
Mar 29, 2024

Commits on Mar 25, 2024

  1. fs/xfstests: Add inih devel dependency for xfsprog

    Using upstream as a target to compile xfsprogs code, following
    failure is encountered:
    
    Command 'make' failed.\nstdout: b"libtoolize -c -i -f\nlibtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, '.'.\nlibtoolize: copying file './config.guess'\nlibtoolize: copying file './config.sub'\nlibtoolize: copying file './install-sh'\nlibtoolize: ... (5.46 s)
    
    Add inih-devel package as dependency so that this package will be
    installed.
    
    Signed-off-by: Sachin Sant <[email protected]>
    sacsant committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    74f107d View commit details
    Browse the repository at this point in the history
  2. fs/xfstests: Move local.config copy operation

    With upstream as a target, xfstest test fails to copy local.config
    
    (1/1) fs/xfstests.py:Xfstests.test;run-disk_type-fs_type-fs_xfs_4k-run_type-upstream-8eea: ERROR: stat: path should be string, bytes, os.PathLike or integer, not NoneType (23.60 s)
    
    This happens since teststmpdir directory is changed during compilation
    of upstream code (various progs).
    
    Move the stub before the upstream as a target check stanza to avoid
    this failure.
    
    Signed-off-by: Sachin Sant <[email protected]>
    sacsant committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    8948eff View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. fs/xfstests: Move package installation after variable initialization

    In case a certain package install operation fails, the test fails
    with a completely different message
    
    ERROR: 'Xfstests' object has no attribute 'scratch_mnt' (15.37 s)
    
    The package install function is called before various variable
    initialization. In case of install fail, test errors out due
    to usage of uniniitalized variables in teardown.
    
    Move the package install function call post variable initialization
    
    Signed-off-by: Sachin Sant <[email protected]>
    sacsant committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    144455c View commit details
    Browse the repository at this point in the history
  2. fs/xfstests: Update package dependency

    On SUSE some of the packages used by xfstest script are available
    with a different name.
    
    Update the __setUp_packages function accordingly to use the correct
    package names.
    
    Signed-off-by: Sachin Sant <[email protected]>
    sacsant committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    3fc8e18 View commit details
    Browse the repository at this point in the history