-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapting the new changes made in htx setup/configuration. #2793
Adapting the new changes made in htx setup/configuration. #2793
Conversation
c478c3e
to
e3fd1d1
Compare
Adding test results below [root@localhost net]# avocado run --max-parallel-tasks=1 htx_nic_devices.py -m htx_nic_devices.py.data/htx_nic_devices.yaml Adding debug.log files to jira id |
8e70f7f
to
f5010be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look into travis fail and also test once for sles and mac id as input instead of interface
c271812
to
df29a4a
Compare
@abdhaleegit @PraveenPenguin I am not seeing any pep8 errors or warning. And also i have done rebase and pushed the code, still i am seeing the travis issue. |
the travis says these are unused in code and can be removed
|
The build_net multisystem command introduced is for automatic configuration of network interfaces on both host and peer. The command set's the interfaces with some local net id's and pings the interfaces. The command also starts the htx deamon creates/selects and activates net.mdt for the network devices. No need to explicitely start the htx deamon or create/select or activate net.mdt file. Also removing the code that was supporting the old htx network topology and made compatible to new configuration changes. Signed-off-by: Tasmiya Nalatwad <[email protected]>
df29a4a
to
e93342c
Compare
@abdhaleegit Tested on sles and code is working fine. Below are the results For "mac id as input instead of interface", i don't see the support for the mac address in the current code. This needs to be added but the interfaces has no role in setting the htx configurations as everything is done by build_net multysystem command. |
lets keep the original code to support mac_id for htx as is.. annyway both interface way and mac way works ..so lets keep it |
@abdhaleegit Yes i have already kept the code as it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The build_net multisystem command introduced is for automatic configuration of network interfaces on both host and peer. The command set's the interfaces with some local net id's and pings the interfaces. The command also starts the htx deamon creates/selects and activates net.mdt for the network devices. No need to explicitely start the htx deamon or create/select or activate net.mdt file.
Also removing the code that was supporting the old htx network topology and made compatible to new configuration changes.