Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapting the new changes made in htx setup/configuration. #2793

Merged

Conversation

TasmiyaNalatwad
Copy link
Contributor

The build_net multisystem command introduced is for automatic configuration of network interfaces on both host and peer. The command set's the interfaces with some local net id's and pings the interfaces. The command also starts the htx deamon creates/selects and activates net.mdt for the network devices. No need to explicitely start the htx deamon or create/select or activate net.mdt file.

Also removing the code that was supporting the old htx network topology and made compatible to new configuration changes.

@TasmiyaNalatwad
Copy link
Contributor Author

Adding test results below

[root@localhost net]# avocado run --max-parallel-tasks=1 htx_nic_devices.py -m htx_nic_devices.py.data/htx_nic_devices.yaml
JOB ID : cd063ac7c3e1cb2fa2803b344a353f3e93a2e074
JOB LOG : /root/avocado-fvt-wrapper/results/job-2024-04-01T07.27-cd063ac/job.log
(1/3) htx_nic_devices.py:HtxNicTest.test_start;run-e730: STARTED
(1/3) htx_nic_devices.py:HtxNicTest.test_start;run-e730: PASS (155.26 s)
(2/3) htx_nic_devices.py:HtxNicTest.test_check;run-e730: STARTED
(2/3) htx_nic_devices.py:HtxNicTest.test_check;run-e730: PASS (128.17 s)
(3/3) htx_nic_devices.py:HtxNicTest.test_stop;run-e730: STARTED
(3/3) htx_nic_devices.py:HtxNicTest.test_stop;run-e730: PASS (21.66 s)
RESULTS : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado-fvt-wrapper/results/job-2024-04-01T07.27-cd063ac/results.html
JOB TIME : 318.87 s

Adding debug.log files to jira id

@TasmiyaNalatwad TasmiyaNalatwad force-pushed the htx_nic_changes branch 3 times, most recently from 8e70f7f to f5010be Compare April 1, 2024 14:12
@abdhaleegit abdhaleegit self-assigned this Apr 1, 2024
Copy link
Collaborator

@abdhaleegit abdhaleegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look into travis fail and also test once for sles and mac id as input instead of interface

@TasmiyaNalatwad TasmiyaNalatwad force-pushed the htx_nic_changes branch 3 times, most recently from c271812 to df29a4a Compare April 2, 2024 11:39
@TasmiyaNalatwad
Copy link
Contributor Author

TasmiyaNalatwad commented Apr 2, 2024

@abdhaleegit @PraveenPenguin I am not seeing any pep8 errors or warning. And also i have done rebase and pushed the code, still i am seeing the travis issue.

@abdhaleegit
Copy link
Collaborator

@abdhaleegit @PraveenPenguin I am not seeing any pep8 errors or warning. And also i have done rebase and pushed the code, still i am seeing the travis issue.

the travis says these are unused in code and can be removed

from avocado.utils import build
from avocado.utils import archive
from avocado.utils.process import CmdError

The build_net multisystem command introduced is for automatic configuration
of network interfaces on both host and peer.
The command set's the interfaces with some local net id's and pings the interfaces.
The command also starts the htx deamon creates/selects and activates net.mdt
for the network devices.
No need to explicitely start the htx deamon or create/select or activate net.mdt file.

Also removing the code that was supporting the old htx network topology and
made compatible to new configuration changes.

Signed-off-by: Tasmiya Nalatwad <[email protected]>
@TasmiyaNalatwad
Copy link
Contributor Author

TasmiyaNalatwad commented Apr 4, 2024

@abdhaleegit Tested on sles and code is working fine. Below are the results
JOB ID : f0739ce487105394fb2e498ed0a99ae2e8454df3
JOB LOG : /root/avocado-fvt-wrapper/results/job-2024-04-04T07.00-f0739ce/job.log
(1/3) htx_nic_devices.py:HtxNicTest.test_start;run-ebbd: STARTED
(1/3) htx_nic_devices.py:HtxNicTest.test_start;run-ebbd: PASS (243.18 s)
(2/3) htx_nic_devices.py:HtxNicTest.test_check;run-ebbd: STARTED
(2/3) htx_nic_devices.py:HtxNicTest.test_check;run-ebbd: PASS (129.30 s)
(3/3) htx_nic_devices.py:HtxNicTest.test_stop;run-ebbd: STARTED
(3/3) htx_nic_devices.py:HtxNicTest.test_stop;run-ebbd: PASS (12.76 s)

For "mac id as input instead of interface", i don't see the support for the mac address in the current code. This needs to be added but the interfaces has no role in setting the htx configurations as everything is done by build_net multysystem command.
I am using interfaces just to flush the addresses before starting the test and at the cleanup part. Nothing to do with interfaces other than this.
So is it required to add support for mac ids?

@abdhaleegit
Copy link
Collaborator

For "mac id as input instead of interface", i don't see the support for the mac address in the current code. This needs to be added but the interfaces has no role in setting the htx configurations as everything is done by build_net multysystem command. I am using interfaces just to flush the addresses before starting the test and at the cleanup part. Nothing to do with interfaces other than this. So is it required to add support for mac ids?

lets keep the original code to support mac_id for htx as is.. annyway both interface way and mac way works ..so lets keep it

@TasmiyaNalatwad
Copy link
Contributor Author

For "mac id as input instead of interface", i don't see the support for the mac address in the current code. This needs to be added but the interfaces has no role in setting the htx configurations as everything is done by build_net multysystem command. I am using interfaces just to flush the addresses before starting the test and at the cleanup part. Nothing to do with interfaces other than this. So is it required to add support for mac ids?

lets keep the original code to support mac_id for htx as is.. annyway both interface way and mac way works ..so lets keep it

@abdhaleegit Yes i have already kept the code as it is.

@abdhaleegit abdhaleegit self-requested a review April 19, 2024 06:18
Copy link
Collaborator

@abdhaleegit abdhaleegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abdhaleegit abdhaleegit merged commit 1c89f50 into avocado-framework-tests:master Apr 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants