Read dawr with perf interface #2869
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new test cases for reading single DAWR register and multiple DAWR registers with perf interface Signed-off-by: Akanksha J N <[email protected]>
|
Opened this PR based on the below comment : #2772 (comment) |
sacsant
suggested changes
Aug 12, 2024
| if not any(x in val for x in power_ver): | ||
| self.cancel("LPAR on Power10 and above is required for this test.") | ||
| if "power10" not in cpu.get_family(): | ||
| self.cancel("Test is supported only on IBM POWER10 platform") |
There was a problem hiding this comment.
This will revert the power11 support changes. Can you rebase the code?
| i = 0 | ||
| if self.distro_name == "fedora": | ||
| child.sendline('set debuginfod enabled on') | ||
| child.expect_exact([pexpect.TIMEOUT, '']) |
There was a problem hiding this comment.
Same. This will revert code added via trace: Add Fedora Support to trace testing. Can you rebase?
| """ | ||
| Setting Read/Write watchpoints on two variables using awatch and | ||
| executing the program | ||
| """ | ||
| child, return_value = self.run_cmd('dawr_v2') | ||
| i = 0 | ||
| if self.distro_name == "fedora": | ||
| child.sendline('set debuginfod enabled on') | ||
| child.expect_exact([pexpect.TIMEOUT, '']) |
PraveenPenguin
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
@akanksha216 just adopts suggestion from @sacsant so we are good to go
|
@PraveenPenguin should we ask someone on behalf of Akanksha to resubmit this PR? |
@sacsant i am working to add these changes using the maintainer ACL so we should not drop Akanksha's credit , i closed another PR to take care same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new test cases for reading single DAWR register and multiple DAWR registers with perf interface