From b3a9cc355422839cdbf24c751fd2f0487a750414 Mon Sep 17 00:00:00 2001 From: Slancaster1 Date: Tue, 9 Jul 2024 12:24:13 -0400 Subject: [PATCH] virttest/virt_admin.py: Provide better Error Msg -- The Issue To ensure the virt-admin interactive shell is alive, a "uri" command is executed However, the output of this command is ignored. This makes debugging a failure of this command hard. -- The Fix Print the output of the error Signed-off-by: Slancaster1 --- virttest/virt_admin.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/virttest/virt_admin.py b/virttest/virt_admin.py index af25f288e1..77adb8d839 100644 --- a/virttest/virt_admin.py +++ b/virttest/virt_admin.py @@ -209,13 +209,14 @@ def __init__( # fail if libvirtd is not running if check_libvirtd: - if self.cmd_status("uri", timeout=60) != 0: + status, out = self.cmd_status_output("uri", timeout=60) + if status != 0: LOG.debug( "Persistent virt-admin session is not responding, " "libvirtd may be dead." ) self.auto_close = True - raise aexpect.ShellStatusError(virtadmin_exec, "uri") + raise aexpect.ShellStatusError(virtadmin_exec, out) def cmd_status_output( self, cmd, timeout=60, internal_timeout=None, print_func=None, safe=False