Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_controller_xml function uses defaults that create invalid controllers #3630

Open
vasekhodina opened this issue Feb 21, 2023 · 1 comment

Comments

@vasekhodina
Copy link

vasekhodina commented Feb 21, 2023

In create_controller_xml function there are defaults for type and model:

contr_type = contr_dict.get("controller_type", 'scsi')
 contr_model = contr_dict.get("controller_model", "virtio-scsi")

However sata type controllers do not have models. The look like this:

<controller type='sata' index='0'>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x1f' function='0x2'/>
</controller>

But when create_controller_xml() is used it created controller like this:

<controller type='sata' model='virtio-scsi' index='0'>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x1f' function='0x2'/>
 </controller>

And then the vm define or vm start command fails.

@dzhengfy
Copy link
Contributor

dzhengfy commented Feb 22, 2023

@vasekhodina , thanks for finding this bug. sata controller is seldom tested, so we did not find this bug before. There should be an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants