You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As Avocado's runners are replacing the stdout and stderr of the tests with a custom StreamToQueue class, it might be a better idea if this StreamToQueue inherits from or has behavior that is more compatible with python's default stdout. A test script or test utility downstream might for instance do if stdout.isatty that will result in breakage because it might not necessarily assume Avocado has swapped the output channels (e.g. if the code is used in more general scopes beyond avocado). Do you think we should make the StreamToQueue objects more compatible with stdout objects or do you think there is a problem in the argument here?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
As Avocado's runners are replacing the stdout and stderr of the tests with a custom
StreamToQueue
class, it might be a better idea if thisStreamToQueue
inherits from or has behavior that is more compatible with python's default stdout. A test script or test utility downstream might for instance doif stdout.isatty
that will result in breakage because it might not necessarily assume Avocado has swapped the output channels (e.g. if the code is used in more general scopes beyond avocado). Do you think we should make theStreamToQueue
objects more compatible with stdout objects or do you think there is a problem in the argument here?Beta Was this translation helpful? Give feedback.
All reactions