Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing the Method of Obtaining CPU Version Information #5719

Closed
wants to merge 1 commit into from
Closed

Conversation

ut003460
Copy link
Contributor

@ut003460 ut003460 commented Jul 11, 2023

  1. By using the get() method to obtain matching patterns, it avoids using try exception to capture KeyError exceptions.
  2. Immediately return the result after finding the version number to avoid unnecessary iteration.
  3. Use an empty string as the default return result to avoid returning None

@richtja
Copy link
Contributor

richtja commented Jul 11, 2023

Hi @ut003460, thank you for your contribution in Avocado. Before we will do review, can you please write down into a commit message a better description of your changes with explanation and your signature. You can follow our contribution guidelines. You can do the changes with force-push and If you need any help, don't hesitate to ask.

@ut003460 ut003460 closed this Jul 12, 2023
@ut003460 ut003460 reopened this Jul 12, 2023
@ut003460
Copy link
Contributor Author

Hi @ut003460, thank you for your contribution in Avocado. Before we will do review, can you please write down into a commit message a better description of your changes with explanation and your signature. You can follow our contribution guidelines. You can do the changes with force-push and If you need any help, don't hesitate to ask.

Thank you for the reminder. A note has been added

@ut003460 ut003460 closed this Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants