Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host.py: method to get all the mac addresses #5751

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

abdhaleegit
Copy link
Contributor

Gets you a list of all hardware addresses for the
given host (local and remote)

Gets you a list of all hardware addresses for the
given host (local and remote)

Signed-off-by: Abdul Haleem <[email protected]>
@mr-avocado
Copy link

mr-avocado bot commented Aug 24, 2023

Dear contributor,
Avocado is currently under sprint #103, which is due to release an LTS (Long Term Stability) release.
Please avoid merging changes that do not fall into these categories:

  • Bug fixes
  • Usability Improvements
  • Documentation updates

As for the Avocado utility modules (“avocado.utils”) it is OK to introduce new functionality,
but changes to the existing APIs (including interface and behavior) should be avoided.
These kind of changes should wait until sprint #104.

@abdhaleegit
Copy link
Contributor Author

Works fine for both local and remote host, this will be used in test to validate if given mac exists in the list

        local = LocalHost()
        print(local.get_all_hwaddr())

        self.remotehost = RemoteHost(self.peer, self.peer_user,
                                                          password=self.peer_password)
        print(self.remotehost.get_all_hwaddr())

Copy link
Contributor

@Naresh-ibm Naresh-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just take care of build failures

Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richtja richtja merged commit f07f661 into avocado-framework:master Aug 28, 2023
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants