Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of numeric codes and commands #92

Open
avojak opened this issue Jan 1, 2021 · 0 comments
Open

Improve handling of numeric codes and commands #92

avojak opened this issue Jan 1, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@avojak
Copy link
Owner

avojak commented Jan 1, 2021

Rather than using a bunch of static consts for the numerics and commands it would probably be better to use enum(s) which can hold the numeric or string value as a property. This would also allow us to group by error/non-error and have a default handler rather than needing to specifically list cases for each (e.g. we can handle cases specifically when it makes sense for better formatting, but have a default to display error/message content rather than silently dropping messages).

@avojak avojak added the enhancement New feature or request label Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant