Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Rename ScalePrecision to AvroDecimal #189

Closed
Chuckame opened this issue Apr 10, 2024 · 3 comments · Fixed by #191
Closed

feat!: Rename ScalePrecision to AvroDecimal #189

Chuckame opened this issue Apr 10, 2024 · 3 comments · Fixed by #191
Labels
enhancement New feature or request
Milestone
Version 2

Comments

@Chuckame
Copy link
Contributor

Chuckame commented Apr 10, 2024 •
edited
Loading

Renaming the ScalePrecision annotation to AvroDecimal to unify annotations with the same prefix.

Breaking change

This is removing the ScalePrecision annotation.
@Chuckame Chuckame added the enhancement New feature or request label Apr 10, 2024
@Chuckame Chuckame added this to the Version 2 milestone Apr 10, 2024
@Chuckame Chuckame changed the title Merge ScalePrecision with AvroDecimalLogicalType feat!: Merge ScalePrecision with AvroDecimalLogicalType Apr 10, 2024
This was referenced Apr 10, 2024
Merged
Merged
@Chuckame Chuckame linked a pull request Apr 11, 2024 that will close this issue
feat: Merge ScalePrecision to AvroDecimalLogicalType #191
Merged
@Chuckame
Copy link
Contributor Author

Done in #191

@Chuckame
Copy link
Contributor Author

opening back, waiting for the real release

@Chuckame Chuckame reopened this May 23, 2024
@Chuckame Chuckame changed the title feat!: Merge ScalePrecision with AvroDecimalLogicalType feat!: Rename ScalePrecision to AvroDecimal May 23, 2024
@Chuckame
Copy link
Contributor Author

Released in v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 2
Development

Successfully merging a pull request may close this issue.

feat: Merge ScalePrecision to AvroDecimalLogicalType Chuckame/avro4k
1 participant
@Chuckame