Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] The implementation of ab3dmot #35

Open
zqzqz opened this issue Apr 23, 2024 · 1 comment
Open

[Bug] The implementation of ab3dmot #35

zqzqz opened this issue Apr 23, 2024 · 1 comment
Assignees
@roshambo919
Labels
bug Something isn't working

Comments

@zqzqz
Copy link

zqzqz commented Apr 23, 2024

https://github.com/avstack-lab/lib-avstack-core/blob/main/avstack/modules/tracking/libraries/AB3DMOT/model.py#L108

I suppose the parameter t is the timestamp but the code use t as track ID. The to_del should use t_ID

Local variable t is used as track ID in multiple places in the same function. I guess it would be better to resolve the conflicts.
@roshambo919 roshambo919 self-assigned this Apr 24, 2024
@roshambo919 roshambo919 added the bug Something isn't working label Apr 24, 2024
@roshambo919
Copy link
Member

Thanks Qingzhao, this is a great point. I'll unify the convention when I can get to it.

Keep the bug reports coming if you find things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roshambo919 roshambo919

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roshambo919 @zqzqz