From 901a2b5ec2baacceef11bd7ca12a81ba5497409a Mon Sep 17 00:00:00 2001 From: Alex Wadell Date: Thu, 17 Aug 2023 18:16:15 -0400 Subject: [PATCH 1/5] Remove use of save-state `save-state` is being depreciated: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ --- action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/action.yml b/action.yml index 9ff7c2b..68bb3a0 100644 --- a/action.yml +++ b/action.yml @@ -23,7 +23,7 @@ runs: id: install_pkgjogger run: > PKG_JOGGER_ENV=$(mktemp --directory); - echo "::set-output name=env::$(echo $PKG_JOGGER_ENV)"; + echo "env=$PKG_JOGGER_ENV" >> $GITHUB_STATE julia --color=yes --project="$PKG_JOGGER_ENV" --eval 'using Pkg; Pkg.develop(name="PkgJogger", path="${{ github.action_path }}")' shell: bash From 4b46a3dd37abc7c314517bbe7d4a68224cc7d981 Mon Sep 17 00:00:00 2001 From: Alexius Wadell Date: Thu, 17 Aug 2023 18:20:05 -0400 Subject: [PATCH 2/5] typo: add missing --- action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/action.yml b/action.yml index 68bb3a0..3cbbddc 100644 --- a/action.yml +++ b/action.yml @@ -23,7 +23,7 @@ runs: id: install_pkgjogger run: > PKG_JOGGER_ENV=$(mktemp --directory); - echo "env=$PKG_JOGGER_ENV" >> $GITHUB_STATE + echo "env=$PKG_JOGGER_ENV" >> $GITHUB_STATE; julia --color=yes --project="$PKG_JOGGER_ENV" --eval 'using Pkg; Pkg.develop(name="PkgJogger", path="${{ github.action_path }}")' shell: bash From 5d332066ec011a96f94952dd3bdb1ba56e2e4540 Mon Sep 17 00:00:00 2001 From: Alexius Wadell Date: Thu, 17 Aug 2023 18:22:44 -0400 Subject: [PATCH 3/5] typo: wrapping echo was important Otherwise the value of PKG_JOGGER_ENV as the start gets interpolated (which is nothing) Also fixing inconsistent spacing of emoji --- action.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/action.yml b/action.yml index 3cbbddc..089e64d 100644 --- a/action.yml +++ b/action.yml @@ -23,12 +23,12 @@ runs: id: install_pkgjogger run: > PKG_JOGGER_ENV=$(mktemp --directory); - echo "env=$PKG_JOGGER_ENV" >> $GITHUB_STATE; + echo "env=$(echo $PKG_JOGGER_ENV)" >> $GITHUB_STATE; julia --color=yes --project="$PKG_JOGGER_ENV" --eval 'using Pkg; Pkg.develop(name="PkgJogger", path="${{ github.action_path }}")' shell: bash - - name: ⏱ Run Benchmarks + - name: ⏱ Run Benchmarks id: run_benchmarks run: > ${{ inputs.prefix }} julia --project="${{ steps.install_pkgjogger.outputs.env }}" --color=yes From 11b8287adc5d7cb22fcd59afffb6c3c3b4ced63a Mon Sep 17 00:00:00 2001 From: Alexius Wadell Date: Thu, 17 Aug 2023 20:00:59 -0400 Subject: [PATCH 4/5] feat: simplify action, just install in base environment --- action.yml | 13 +++---------- src/ci.jl | 1 - 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/action.yml b/action.yml index 089e64d..c2ea3db 100644 --- a/action.yml +++ b/action.yml @@ -22,20 +22,13 @@ runs: - name: 🏃 Install PkgJogger id: install_pkgjogger run: > - PKG_JOGGER_ENV=$(mktemp --directory); - echo "env=$(echo $PKG_JOGGER_ENV)" >> $GITHUB_STATE; - julia --color=yes --project="$PKG_JOGGER_ENV" --eval - 'using Pkg; Pkg.develop(name="PkgJogger", path="${{ github.action_path }}")' + julia --color=yes --eval + 'using Pkg; Pkg.develop(PackageSpec(; name="PkgJogger", path="${{ github.action_path }}"))' shell: bash - name: ⏱ Run Benchmarks id: run_benchmarks run: > - ${{ inputs.prefix }} julia --project="${{ steps.install_pkgjogger.outputs.env }}" --color=yes + ${{ inputs.prefix }} julia --color=yes ${{ inputs.options }} --eval 'using PkgJogger; PkgJogger.ci()' shell: bash - - - name: 🧹 Cleanup PkgJogger - id: Cleanup - run: rm -rf "${{ steps.install_pkgjogger.outputs.env }}" - shell: bash diff --git a/src/ci.jl b/src/ci.jl index 3bdfb1d..49f3262 100644 --- a/src/ci.jl +++ b/src/ci.jl @@ -274,4 +274,3 @@ function list_benchmarks(dir) @assert !isempty(r) "No benchmarking results found in $dir" return r end - From c5a99a7778082184a6eb9e29dccf715046806dc7 Mon Sep 17 00:00:00 2001 From: Alexius Wadell Date: Thu, 17 Aug 2023 20:07:26 -0400 Subject: [PATCH 5/5] release: bump patch --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index 58e73ea..e7996ff 100644 --- a/Project.toml +++ b/Project.toml @@ -1,7 +1,7 @@ name = "PkgJogger" uuid = "10150987-6cc1-4b76-abee-b1c1cbd91c01" authors = ["Alexius Wadell and contributors"] -version = "0.4.1" +version = "0.4.2" [deps] BSON = "fbb218c0-5317-5bc6-957e-2ee96dd4b1f0"