-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt out security/consistency features #41
base: master
Are you sure you want to change the base?
Conversation
- ignoring order doesn't work yet as checksum will be fetched by the index, not id
9797be0
to
e5e59bc
Compare
src/migration.js
Outdated
if(this.steps[index]){ | ||
this.steps[index].status = statuses.skipped; | ||
|
||
if(!_steps[dbStep.id] || (dbStep.order && dbStep.order != _steps[dbStep.id].order)){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when writing the test for ignoreOrder i realized there's a problem with dbStep.order as it evaluates to false when order is 0
Can this PR be merged? |
@BarryOwens sorry i lost touch to the codebase as I needed access to the new mongo driver and opt out of the security related features :/ - therefore i created a not necessary better package to satisfy my needs. Feel free to close this pr(or to pick it up and integrate it, but i cannot remember in which state it is) |
What is the status of this issue? I would need a possibility to skip steps or disable checksum validation because I need to replace an existing mirgration, because there was an error in it. |
Was this already merged? I need this feature too, cause of some refactorings. |
Add a new optional options parameter:
which can be used to disable file order checking and checksums.