Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt out security/consistency features #41

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sakulstra
Copy link
Contributor

Add a new optional options parameter:

new Migration(dbConfig, options);

which can be used to disable file order checking and checksums.


sakulstra added 3 commits May 9, 2018 11:04
- ignoring order doesn't work yet as checksum will be fetched by the index, not id
@sakulstra sakulstra force-pushed the opt-out-security branch from 9797be0 to e5e59bc Compare May 9, 2018 10:49
src/migration.js Outdated
if(this.steps[index]){
this.steps[index].status = statuses.skipped;

if(!_steps[dbStep.id] || (dbStep.order && dbStep.order != _steps[dbStep.id].order)){
Copy link
Contributor Author

@sakulstra sakulstra May 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when writing the test for ignoreOrder i realized there's a problem with dbStep.order as it evaluates to false when order is 0

@BarryOwens
Copy link

Can this PR be merged?

@sakulstra
Copy link
Contributor Author

sakulstra commented Oct 29, 2018

@BarryOwens sorry i lost touch to the codebase as I needed access to the new mongo driver and opt out of the security related features :/ - therefore i created a not necessary better package to satisfy my needs. Feel free to close this pr(or to pick it up and integrate it, but i cannot remember in which state it is)

@jzwiesler
Copy link

What is the status of this issue? I would need a possibility to skip steps or disable checksum validation because I need to replace an existing mirgration, because there was an error in it.

@j0meinaster
Copy link

Was this already merged? I need this feature too, cause of some refactorings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable checksum
4 participants