Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authenticator): add angular support for email mfa #6356

Merged
merged 53 commits into from
Mar 1, 2025

Conversation

jjarvisp
Copy link
Member

Description of changes

The purpose of this pull request is to expand authenticator support for email mfa in the Angular framework.

The Angular authenticator now renders two new screens in response to the two new states added to the state machine in #6317. This update allows completion of email MFA based sign ins, email MFA setup, and the selection challenges that allow users to choose which MFA method to setup or sign in with.

selectMfaType -> SelectMfaType : CONTINUE_SIGN_IN_WITH_MFA_SETUP and CONTINUE_SIGN_IN_WITH_MFA_SELECTION
setupEmail -> SetupEmail : CONTINUE_SIGN_IN_WITH_EMAIL_SETUP

This update also adds a new radio-group-field component for usage specifically in the selectMfaType screen.

Issue #, if available

Description of how you validated changes

  • manual testing
  • unit tests
  • e2e tests

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jjarvisp jjarvisp requested a review from a team as a code owner February 15, 2025 00:47
Copy link

changeset-bot bot commented Feb 15, 2025

⚠️ No Changeset found

Latest commit: d19b908

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/angular-updates branch from 92ffea5 to 74109a8 Compare February 17, 2025 19:20
@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/react-updates branch 2 times, most recently from 7f27d61 to c46c2ec Compare February 22, 2025 20:42
@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/react-updates branch from c46c2ec to f69c422 Compare February 22, 2025 20:52
@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/angular-updates branch from 74109a8 to b81b5a8 Compare February 23, 2025 00:06
calebpollman
calebpollman previously approved these changes Feb 26, 2025
Base automatically changed from james/feat-email-mfa/react-updates to feat-email-mfa/main February 28, 2025 22:42
@jjarvisp jjarvisp dismissed calebpollman’s stale review February 28, 2025 22:42

The base branch was changed.

@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/angular-updates branch from 356e3cf to 2bdcc03 Compare February 28, 2025 23:53
@jjarvisp jjarvisp merged commit bc61bc0 into feat-email-mfa/main Mar 1, 2025
32 checks passed
@jjarvisp jjarvisp deleted the james/feat-email-mfa/angular-updates branch March 1, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants