Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should we handle the erlang ref in the response from aws-erlang #132

Open
andreashasse opened this issue Feb 22, 2023 · 0 comments
Open
Labels
good first issue Good for newcomers

Comments

@andreashasse
Copy link
Contributor

andreashasse commented Feb 22, 2023

Background
The result from a successful request to aws-erlang typically looks like this:
{ok, Response, {HttpStatusCode, Headers, Ref}} = .. aws_something:something(...),
The Ref can be used in the API for hackney.
We should not encourage users to call the hackney API as we want to be able to switch from hackney to something else if e.g. Hackney becomes unmaintained.

Solutions
A solution would be to implement a module in aws-erlang where we make the ref opaque and create a wrap module where we tunnel all calls to hackney that could be useful. This would us a little bit more future compatible.

@onno-vos-dev onno-vos-dev added the good first issue Good for newcomers label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants