Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rebar3 format for aws-erlang #136

Open
onno-vos-dev opened this issue Mar 17, 2023 · 1 comment
Open

Use rebar3 format for aws-erlang #136

onno-vos-dev opened this issue Mar 17, 2023 · 1 comment
Labels

Comments

@onno-vos-dev
Copy link
Member

onno-vos-dev commented Mar 17, 2023

rebar3 format is the future nowadays and becoming the industry standard for formatting code. We should follow along and use rebar3 format across the project.

Make use of a .git-blame-ignore-revs file to ignore the formatter commit: https://michaelheap.com/git-ignore-rev/

@onno-vos-dev
Copy link
Member Author

I tried it out and there's a bug in rebar3 format it seems when it comes to dealing with binary comprehensions which we use in aws_util.erl so either we'd have to skip that file for now or wait for a fix of: AdRoll/rebar3_format#342

I'll leave this for some time before seeing if we may want to proceed in the meantime anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant