Feat guard lambda s3 output #240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshayrane
requested changes
May 3, 2022
| if e.s3_output_bucket.is_empty() { | ||
| resp = results_vec; | ||
| }else { | ||
| // No extra configuration is needed as long as your Lambda has |
There was a problem hiding this comment.
If there are prerequisite permissions to be granted to Lambda role, let's add a documentation in README for Lambda for granting required permissions to the access policy such as bucket s3:PutObject action.
|
This item is currently being reviewed. As the AWS SDK is in Developer Preview, this will not be merged to main. Will follow up soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #236
Description of changes:
Added new flag to guard-lambda to send output to S3 bucket
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license