Skip to content

Commit 22a4b21

Browse files
committed
Apply ServiceId as matching field for VPC Endpoint Service
1 parent 944d51d commit 22a4b21

File tree

6 files changed

+23
-24
lines changed

6 files changed

+23
-24
lines changed
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
ack_generate_info:
2-
build_date: "2025-06-16T02:14:15Z"
3-
build_hash: e675923dfc54d8b6e09730098c3e3e1056d3c1e9
4-
go_version: go1.24.0
5-
version: v0.48.0
2+
build_date: "2025-07-08T05:50:37Z"
3+
build_hash: 580a56e85fed07f60089ef2cae634548b523981b
4+
go_version: go1.24.3
5+
version: v0.48.0-2-g580a56e-dirty
66
api_directory_checksum: d162a6e9df2d4861d6c01d42047402b51f341293
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.32.6
99
generator_config_info:
10-
file_checksum: e6a6ff840d55df735215ac04826122ebf89eb79a
10+
file_checksum: eeec264d149c1d6c69144d4cbbd6ac1c8f1f8784
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation

apis/v1alpha1/generator.yaml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -254,12 +254,6 @@ operations:
254254
operation_type:
255255
- Delete
256256
resource_name: VpcEndpointServiceConfiguration
257-
CreateVpcEndpointServiceConfiguration:
258-
output_wrapper_field_path: ServiceConfiguration
259-
DeleteVpcEndpointServiceConfigurations:
260-
operation_type:
261-
- Delete
262-
resource_name: VpcEndpointServiceConfiguration
263257
CreateFlowLogs:
264258
operation_type:
265259
- Create
@@ -1069,6 +1063,9 @@ resources:
10691063
- path: Status.ServiceState
10701064
in:
10711065
- available
1066+
list_operation:
1067+
match_fields:
1068+
- ServiceId
10721069
hooks:
10731070
sdk_delete_post_build_request:
10741071
template_path: hooks/vpc_endpoint_service_configuration/sdk_delete_post_build_request.go.tpl

generator.yaml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -254,12 +254,6 @@ operations:
254254
operation_type:
255255
- Delete
256256
resource_name: VpcEndpointServiceConfiguration
257-
CreateVpcEndpointServiceConfiguration:
258-
output_wrapper_field_path: ServiceConfiguration
259-
DeleteVpcEndpointServiceConfigurations:
260-
operation_type:
261-
- Delete
262-
resource_name: VpcEndpointServiceConfiguration
263257
CreateFlowLogs:
264258
operation_type:
265259
- Create
@@ -1069,6 +1063,9 @@ resources:
10691063
- path: Status.ServiceState
10701064
in:
10711065
- available
1066+
list_operation:
1067+
match_fields:
1068+
- ServiceId
10721069
hooks:
10731070
sdk_delete_post_build_request:
10741071
template_path: hooks/vpc_endpoint_service_configuration/sdk_delete_post_build_request.go.tpl

pkg/resource/elastic_ip_address/sdk.go

Lines changed: 2 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/resource/vpc_endpoint_service_configuration/sdk.go

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/e2e/tests/test_vpc_endpoint_service_configuration_adoption.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,13 @@
4141
@pytest.fixture
4242
def vpc_endpoint_service_adoption():
4343
replacements = REPLACEMENT_VALUES.copy()
44-
resource_name = random_suffix_name("vpc-es-adoption", 32)
44+
resource_name = random_suffix_name("vpc-es-adoption", 24)
4545
service_id = get_bootstrap_resources().AdoptedVpcEndpointService.service_id
46-
replacements["VPC_ADOPTION_NAME"] = resource_name
46+
assert service_id is not None
47+
48+
replacements["VPC_ENDPOINT_SERVICE_ADOPTED_NAME"] = resource_name
4749
replacements["ADOPTION_POLICY"] = "adopt"
48-
replacements["ADOPTION_FIELDS"] = f"{{\\\"serviceId\\\": \\\"{service_id}\\\"}}"
50+
replacements["ADOPTION_FIELDS"] = f"{{\\\"serviceID\\\": \\\"{service_id}\\\"}}"
4951

5052
resource_data = load_ec2_resource(
5153
"vpc_endpoint_service_adoption",
@@ -77,6 +79,8 @@ class TestVpcAdoption:
7779
def test_vpc_endpoint_service_configuration_adopt_update(self, ec2_client, vpc_endpoint_service_adoption):
7880
(ref, cr) = vpc_endpoint_service_adoption
7981

82+
time.sleep(CREATE_WAIT_AFTER_SECONDS)
83+
8084
assert cr is not None
8185
assert 'status' in cr
8286
assert 'serviceID' in cr['status']

0 commit comments

Comments
 (0)