Skip to content

Commit 3a9810e

Browse files
authored
feat(rule): add resolve references for targetgroups (#61)
Issue [#2641](aws-controllers-k8s/community#2641) Description of changes: Ensure we resolve references for elbv2 `rule.actions.forwardconfig.targetgroups` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent ba0f5db commit 3a9810e

File tree

6 files changed

+99
-22
lines changed

6 files changed

+99
-22
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
ack_generate_info:
2-
build_date: "2025-09-25T18:46:28Z"
2+
build_date: "2025-09-26T17:23:37Z"
33
build_hash: 5bf1e456e1dfc638d47ab492376335f528c0f455
44
go_version: go1.24.5
55
version: v0.52.0-1-g5bf1e45
66
api_directory_checksum: c0850c127b1c1c46a7abf233f454e1c7c561a71c
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.32.6
99
generator_config_info:
10-
file_checksum: e59ecda70fd052399089af65a682c10fe45d58a5
10+
file_checksum: d04b5f7d437623f4ddc566ea1f2e6b068125115e
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation

apis/v1alpha1/generator.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,10 @@ resources:
213213
references:
214214
resource: TargetGroup
215215
path: Status.ACKResourceMetadata.ARN
216+
Actions.ForwardConfig.TargetGroups.TargetGroupARN:
217+
references:
218+
resource: TargetGroup
219+
path: Status.ACKResourceMetadata.ARN
216220
Priority:
217221
set:
218222
- ignore: true

generator.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,10 @@ resources:
213213
references:
214214
resource: TargetGroup
215215
path: Status.ACKResourceMetadata.ARN
216+
Actions.ForwardConfig.TargetGroups.TargetGroupARN:
217+
references:
218+
resource: TargetGroup
219+
path: Status.ACKResourceMetadata.ARN
216220
Priority:
217221
set:
218222
- ignore: true

pkg/resource/rule/references.go

Lines changed: 81 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/e2e/resources/rule.yaml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,13 @@ spec:
66
priority: 300
77
listenerARN: $LISTENER_ARN
88
actions:
9-
- type: "forward"
10-
targetGroupARN: $TARGET_GROUP_ARN
9+
- forwardConfig:
10+
targetGroups:
11+
- targetGroupRef:
12+
from:
13+
name: $TARGET_GROUP_NAME
14+
weight: 1
15+
type: forward
1116
conditions:
1217
- field: http-request-method
1318
httpRequestMethodConfig:

test/e2e/tests/test_rule.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def simple_rule(elbv2_client, simple_listener, simple_target_group, simple_load_
4545
replacements = REPLACEMENT_VALUES.copy()
4646
replacements["RULE_NAME"] = resource_name
4747
replacements["LISTENER_ARN"] = listener_cr["status"]["ackResourceMetadata"]["arn"]
48-
replacements["TARGET_GROUP_ARN"] = target_group_cr["status"]["ackResourceMetadata"]["arn"]
48+
replacements["TARGET_GROUP_NAME"] = target_group_cr["spec"]["name"]
4949

5050
resource_data = load_elbv2_resource(
5151
"rule",

0 commit comments

Comments
 (0)