Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: add test for integration_data_interface_version #113

Open
joel-wong-aws opened this issue Feb 6, 2025 · 0 comments
Open

Maintenance: add test for integration_data_interface_version #113

joel-wong-aws opened this issue Feb 6, 2025 · 0 comments
Labels
good first issue Good for newcomers maintenance Changes to builds, tests, processes, or code that does not directly affect functionality

Comments

@joel-wong-aws
Copy link
Contributor

Description

When the init_data.schema.yaml or run_data.schema.yaml is changed, the adaptor's integration_data_interface_version should also be increased. We have a note in the pull request template that this is a breaking change, but the instructions only indicate to include an ! in your conventional commit title and to add instructions for upgrading to the PR. However, they don't indicate that you need to increase the integration_data_interface_version, which could be missed.

We should add tests that if the init_data.schema.yaml or run_data.schema.yaml is changed, the integration_data_interface_version is also increased.

Solution

Here is the test we added for a different Deadline Cloud integration for this. A similar test can be added to this repository.

@joel-wong-aws joel-wong-aws added needs triage A new issue that needs a first look good first issue Good for newcomers and removed needs triage A new issue that needs a first look labels Feb 6, 2025
@joel-wong-aws joel-wong-aws added the maintenance Changes to builds, tests, processes, or code that does not directly affect functionality label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers maintenance Changes to builds, tests, processes, or code that does not directly affect functionality
Projects
None yet
Development

No branches or pull requests

1 participant