GitHub Self-Managed CodeStar Connection Fails

[ari-luokkala]

Terraform Version & Prov:
OSS
1.8.5

AFT Version:
1.13.2

Terraform Version & Provider Versions
Terraform v1.8.5

• provider registry.terraform.io/hashicorp/archive v2.6.0
• provider registry.terraform.io/hashicorp/aws v5.78.0
• provider registry.terraform.io/hashicorp/local v2.5.2
• provider registry.terraform.io/hashicorp/random v3.6.3
• provider registry.terraform.io/hashicorp/time v0.12.1

Bug Description
Deployment with GitLab self-managed VCS fails.
The resource name for aws_codestarconnections_connection.gitlabselfmanaged is too long by default.

Failed resource
resource "aws_codestarconnections_connection" "gitlabselfmanaged" {
count = local.vcs.is_gitlab_selfmanaged ? 1 : 0
name = "ct-aft-gitlab-selfmanaged-connection"
host_arn = aws_codestarconnections_host.gitlabselfmanaged[0].arn
}

To Reproduce
Steps to reproduce the behavior:
Deploy AFT with GitLab self-managed parameters for VCS.

Expected behavior
Deployment would succeed.

Related Logs
Error: creating CodeStar Connections Connection (ct-aft-gitlab-selfmanaged-connection): operation error CodeStar connections: CreateConnection, https response error StatusCode: 400, RequestID: xxx, api error ValidationException: 1 validation error detected: Value 'ct-aft-gitlab-selfmanaged-connection' at 'connectionName' failed to satisfy constraint: Member must have length less than or equal to 32
on .terraform/modules/aft/modules/aft-code-repositories/codestar.tf line 44, in resource resource "aws_codestarconnections_connection" "gitlabselfmanaged" {

Additional context
N/A

[matthewbarreiro]

This is a duplicate of #508

In either case, this means the GitLab Self Managed support doesn't actually work right now!