Add optional var for VPC ARN #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drewster727
requested review from
tonynv,
andrew-glenn,
tlindsay42 and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional var for VPC ARN.
Allowing you to avoid subsequent data queries to get the VPC ARN when creating secondary VPC CIDR, which avoids an issue where Cloud WAN / Network Manager VPC attachment wants to get recreated.
This solution will still fallback on the data query if no VPC ARN is provided.
Realistically, we should not have to do this (the data query should present the same VPC ARN), but I'm not seeing any way to resolve this without going further upstream to the AWS provider?
This fixes #162