Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the Public Layer ARN for aws-lambda-powertools-python-layer-extras in the docs #1171

Closed
hilgefjm opened this issue Mar 4, 2022 · 8 comments · Fixed by #1610
Closed
Assignees
Labels
feature-request feature request v2

Comments

@hilgefjm
Copy link

hilgefjm commented Mar 4, 2022

Runtime:
Python

Is your feature request related to a problem? Please describe
I have followed the alternative solution to publish aws-lambda-powertools-python into my organization's Gov Cloud account suggested in #1166, which works well; however, one of my teams has asked to use the Parser utility and thus requires aws-lambda-powertools-python-layer-extras. I can not find any documented reference to the aws-lambda-powertools-python-layer-extras layer ARN, and the layer ARN is not returned from any CLI calls interacting with with SAR such as:

aws serverlessrepo get-application --application-id arn:aws:serverlessrepo:eu-west-1:057560766410:applications/aws-lambda-powertools-python-layer-extras

Describe the solution you'd like
Similar to how the public layer ARN is documented as arn:aws:lambda:${AWS::Region}:017000801446:layer:AWSLambdaPowertoolsPython:11, I would like to see a reference for the layer containing the extras so that I am capable of rehosting it within my Gov Cloud account (until such a time as it is hosted publicly within Gov Cloud by the maintainers).

Describe alternatives you've considered
I have considered trying to reference the SAR using SAM/CDK, but to my knowledge the resource arn:aws:serverlessrepo:eu-west-1:057560766410:applications/aws-lambda-powertools-python-layer-extras is not capable of being referenced from within a Gov Cloud partition.

Additional context
Here is a screenshot of the current state of the documentation without the extras layer ARN for reference:
image

@michaelbrewer
Copy link
Contributor

@ran-isenberg i am sure you can or would like to answer thing one :)

@hilgefjm otherwise you might want to log this issue under the Python project?

@michaelbrewer
Copy link
Contributor

@hilgefjm this is related to Gov Cloud in general #1166

@ran-isenberg
Copy link
Contributor

There used be a layer with pydantic.
I dont use it as it's harder to sync the local version of pydantic in the ide and the lambda layer.
I create my own layer.
You can see an example here: https://github.com/ran-isenberg/aws-lambda-handler-cookbook/blob/main/cdk/aws_lambda_handler_cookbook/service_stack/cookbook_construct.py
look at the _build_common_layer function

@boring-cyborg
Copy link

boring-cyborg bot commented Apr 28, 2022

Thanks for opening your first issue here! We'll come back to you as soon as we can.

@heitorlessa heitorlessa transferred this issue from aws-powertools/powertools-lambda Apr 28, 2022
@heitorlessa
Copy link
Contributor

Update: @am29d is working on migrating our internal Lambda Layers pipeline to CodePipeline in a Powertools AWS account. Once that's done (~H2), this will reduce our operational overhead and we will consider expanding our public Layers portfolio (ARM, extras).

You can follow progress here: github.com/orgs/awslabs/projects/51/views/11

@heitorlessa heitorlessa added feature-request feature request need-customer-feedback Requires more customers feedback before making or revisiting a decision and removed Proposed labels Apr 28, 2022
@heitorlessa heitorlessa removed the need-customer-feedback Requires more customers feedback before making or revisiting a decision label Oct 14, 2022
@heitorlessa heitorlessa assigned rubenfonseca and unassigned am29d Oct 14, 2022
@heitorlessa
Copy link
Contributor

assigning to @rubenfonseca as we've managed to solve this beautifully for V2

@heitorlessa heitorlessa added the v2 label Oct 17, 2022
@rubenfonseca rubenfonseca added the pending-release Fix or implementation already in dev waiting to be released label Oct 18, 2022
@rubenfonseca rubenfonseca linked a pull request Oct 18, 2022 that will close this issue
7 tasks
@heitorlessa heitorlessa removed the pending-release Fix or implementation already in dev waiting to be released label Oct 18, 2022
@heitorlessa
Copy link
Contributor

Closing as we're wrap to launch V2.

New Lambda Layer now includes all dependencies, no more need for Extras layer, since we've optimised the size with over 95% reduction

@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request feature request v2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants