Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Warn users when adding multiple values to dimension before flushing #5638

Closed
2 tasks done
leandrodamascena opened this issue Nov 24, 2024 · 3 comments · Fixed by #5653
Closed
2 tasks done
Assignees
Labels

Comments

@leandrodamascena
Copy link
Contributor

Use case

Original issue in TypeScript: aws-powertools/powertools-lambda-typescript#3350

When a user adds multiple values to a single dimension before flushing metrics, only the last value set on the dimension wins.

Solution/User Experience

It would be nice if the metrics object would do a warnings.warning when multiple distinct values are used on a single dimension before flushing. Current behavior uses the last value added to the dimension.

Alternative solutions

Acknowledgment

@leandrodamascena
Copy link
Contributor Author

Assigning to @anafalcao

@leandrodamascena leandrodamascena moved this from Triage to Working on it in Powertools for AWS Lambda (Python) Nov 25, 2024
@leandrodamascena leandrodamascena added metrics and removed triage Pending triage from maintainers labels Nov 25, 2024
@anafalcao anafalcao linked a pull request Nov 26, 2024 that will close this issue
7 tasks
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (Python) Nov 26, 2024
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Nov 26, 2024
Copy link
Contributor

This is now released under 3.4.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Coming soon
Development

Successfully merging a pull request may close this issue.

2 participants