Skip to content

Commit 4440aa8

Browse files
committed
address PR feedback
1 parent cdca132 commit 4440aa8

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

packages/logger/tests/unit/workingWithkeys.test.ts

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { log } from 'node:console';
21
import { setTimeout } from 'node:timers/promises';
32
import context from '@aws-lambda-powertools/testing-utils/context';
43
import middy from '@middy/core';
@@ -828,7 +827,7 @@ describe('Working with keys', () => {
828827
);
829828

830829
describe('deprecated persistentLogAttributes usage', () => {
831-
it('should set #attributesStore on the logger', () => {
830+
it('sets #attributesStore on the logger', () => {
832831
// Prepare
833832
const logger = new Logger({
834833
persistentLogAttributes: {
@@ -849,7 +848,7 @@ describe('Working with keys', () => {
849848
);
850849
});
851850

852-
it('should get overridden by persistentKeys usage', () => {
851+
it('gets overridden by persistentKeys usage', () => {
853852
// Prepare
854853
const logger = new Logger({
855854
persistentKeys: {
@@ -874,7 +873,7 @@ describe('Working with keys', () => {
874873
);
875874
});
876875

877-
it('should persist for child loggers', () => {
876+
it('persists for child loggers', () => {
878877
// Prepare
879878
const logger = new Logger({
880879
persistentLogAttributes: {
@@ -898,7 +897,7 @@ describe('Working with keys', () => {
898897
);
899898
});
900899

901-
it('should persist for child loggers using persistentLogAttributes', () => {
900+
it('persists for child loggers using persistentLogAttributes', () => {
902901
// Prepare
903902
const logger = new Logger({
904903
persistentLogAttributes: {
@@ -927,7 +926,7 @@ describe('Working with keys', () => {
927926
);
928927
});
929928

930-
it('should persist for child loggers using persistKeys', () => {
929+
it('persists for child loggers using persistKeys', () => {
931930
// Prepare
932931
const logger = new Logger({
933932
persistentLogAttributes: {
@@ -956,7 +955,7 @@ describe('Working with keys', () => {
956955
);
957956
});
958957

959-
it('should persist for child loggers using persistentLogAttributes when parent used persistentLogAttributes', () => {
958+
it('persists for child loggers using persistentLogAttributes when parent used persistentLogAttributes', () => {
960959
// Prepare
961960
const logger = new Logger({
962961
persistentLogAttributes: {
@@ -989,7 +988,7 @@ describe('Working with keys', () => {
989988
);
990989
});
991990

992-
it('should persist for child loggers using persistentLogAttributes when parent used persistentKeys', () => {
991+
it('persists for child loggers using persistentLogAttributes when parent used persistentKeys', () => {
993992
// Prepare
994993
const logger = new Logger({
995994
persistentKeys: {

0 commit comments

Comments
 (0)