Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip unwanted partition columns #422

Merged

Conversation

Jeremynadal33
Copy link
Contributor

resolves #421

Description

Modify the function get_columns_in_relation so it does not return unwanted partitions related stuff like "Part 0", "Part 1", ... For more information on this behavior see 421

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-glue next" section.

FYI : There are currently a "fake" tests associated with this function. I can update it to add one but I need information on how to mock a BaseRelation object.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@moomindani moomindani self-assigned this Sep 3, 2024
@moomindani moomindani added the enable-functional-tests This label enable functional tests label Sep 3, 2024
@moomindani moomindani merged commit ef16d45 into aws-samples:main Sep 6, 2024
19 checks passed
@moomindani
Copy link
Collaborator

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor enable-functional-tests This label enable functional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using partitions, the function get_columns_in_relation returns unwanted rows
2 participants