Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeetingManager logs to console even though there is a logger specified #904

Open
5 tasks done
Nanosync opened this issue Jul 16, 2023 · 0 comments
Open
5 tasks done
Labels
Bug Something isn't working Triaged

Comments

@Nanosync
Copy link

What happened and what did you expect to happen?

In MeetingManager, there is a logger object but console calls are made, instead of using logger to make those calls.

https://github.com/aws/amazon-chime-sdk-component-library-react/blob/main/src/providers/MeetingProvider/MeetingManager.ts

Have you reviewed our existing documentation?

Reproduction steps

Any event that occurs in MeetingManager will log to the console.

Amazon Chime SDK React Components Library version

3.5.0

What browsers are you seeing the problem on?

Chrome

Browser version

Version 114.0.5735.198 (Official Build) (arm64)

Device Information

macOS Monterey 12.6.7

Meeting and Attendee ID Information.

No response

Browser console logs

[MeetingManager audioVideoDidStart] Meeting started successfully

Add any other context about the problem here.

All other files within amazon-chime-sdk-component-library-react log to the logger, but only MeetingManager logs to the console directly.

@linsang21 linsang21 added Bug Something isn't working Triaged labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Triaged
Projects
None yet
Development

No branches or pull requests

2 participants