Skip to content

Commit afce053

Browse files
committed
[Fix] Added 'Service' to IntegTests
1 parent 6fa7a14 commit afce053

File tree

3 files changed

+47
-8
lines changed

3 files changed

+47
-8
lines changed

test/efa/efa_test.go

Lines changed: 23 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,20 +37,31 @@ const (
3737
podEfaRdmaReadBytes = "pod_efa_rdma_read_bytes"
3838
podEfaRdmaWriteBytes = "pod_efa_rdma_write_bytes"
3939
podEfaRdmaWriteRecvBytes = "pod_efa_rdma_write_recv_bytes"
40+
podEfaLimit = "pod_efa_limit"
41+
podEfaRequest = "pod_efa_request"
42+
podEfaUsageTotal = "pod_efa_usage_total"
43+
podEfaReservedCapacity = "pod_efa_reserved_capacity"
4044

4145
nodeEfaRxBytes = "node_efa_rx_bytes"
4246
nodeEfaTxBytes = "node_efa_tx_bytes"
4347
nodeEfaRxDropped = "node_efa_rx_dropped"
4448
nodeEfaRdmaReadBytes = "node_efa_rdma_read_bytes"
4549
nodeEfaRdmaWriteBytes = "node_efa_rdma_write_bytes"
4650
nodeEfaRdmaWriteRecvBytes = "node_efa_rdma_write_recv_bytes"
51+
nodeEfaLimit = "node_efa_limit"
52+
nodeEfaUsageTotal = "node_efa_usage_total"
53+
nodeEfaReservedCapacity = "node_efa_reserved_capacity"
54+
nodeEfaUnreservedCapacity = "node_efa_unreserved_capacity"
55+
nodeEfaAvailableCapacity = "node_efa_available_capacity"
4756
)
4857

4958
var expectedDimsToMetricsIntegTest = map[string][]string{
5059
"ClusterName": {
5160
//containerEfaRxBytes, containerEfaTxBytes, containerEfaRxDropped, containerEfaRdmaReadBytes, containerEfaRdmaWriteBytes, containerEfaRdmaWriteRecvBytes,
5261
//podEfaRxBytes, podEfaTxBytes, podEfaRxDropped, podEfaRdmaReadBytes, podEfaRdmaWriteBytes, podEfaRdmaWriteRecvBytes,
5362
nodeEfaRxBytes, nodeEfaTxBytes, nodeEfaRxDropped, nodeEfaRdmaReadBytes, nodeEfaRdmaWriteBytes, nodeEfaRdmaWriteRecvBytes,
63+
podEfaLimit, podEfaRequest, podEfaUsageTotal, podEfaReservedCapacity,
64+
nodeEfaLimit, nodeEfaUsageTotal, nodeEfaReservedCapacity, nodeEfaUnreservedCapacity, nodeEfaAvailableCapacity,
5465
},
5566
//"ClusterName-Namespace-PodName-ContainerName": {
5667
// containerEfaRxBytes, containerEfaTxBytes, containerEfaRxDropped, containerEfaRdmaReadBytes, containerEfaRdmaWriteBytes, containerEfaRdmaWriteRecvBytes,
@@ -61,17 +72,23 @@ var expectedDimsToMetricsIntegTest = map[string][]string{
6172
//"ClusterName-Namespace": {
6273
// podEfaRxBytes, podEfaTxBytes, podEfaRxDropped, podEfaRdmaReadBytes, podEfaRdmaWriteBytes, podEfaRdmaWriteRecvBytes,
6374
//},
64-
//"ClusterName-Namespace-Service": {
65-
// podEfaRxBytes, podEfaTxBytes, podEfaRxDropped, podEfaRdmaReadBytes, podEfaRdmaWriteBytes, podEfaRdmaWriteRecvBytes,
66-
//},
67-
//"ClusterName-Namespace-PodName": {
68-
// podEfaRxBytes, podEfaTxBytes, podEfaRxDropped, podEfaRdmaReadBytes, podEfaRdmaWriteBytes, podEfaRdmaWriteRecvBytes,
69-
//},
75+
"ClusterName-Namespace-Service": {
76+
// podEfaRxBytes, podEfaTxBytes, podEfaRxDropped, podEfaRdmaReadBytes, podEfaRdmaWriteBytes, podEfaRdmaWriteRecvBytes,
77+
podEfaLimit, podEfaRequest, podEfaUsageTotal, podEfaReservedCapacity,
78+
},
79+
"ClusterName-Namespace-PodName": {
80+
// podEfaRxBytes, podEfaTxBytes, podEfaRxDropped, podEfaRdmaReadBytes, podEfaRdmaWriteBytes, podEfaRdmaWriteRecvBytes,
81+
podEfaLimit, podEfaRequest, podEfaUsageTotal, podEfaReservedCapacity,
82+
},
7083
//"ClusterName-Namespace-PodName-FullPodName": {
7184
// podEfaRxBytes, podEfaTxBytes, podEfaRxDropped, podEfaRdmaReadBytes, podEfaRdmaWriteBytes, podEfaRdmaWriteRecvBytes,
7285
//},
86+
"ClusterName-FullPodName-Namespace-PodName": {
87+
podEfaLimit, podEfaRequest, podEfaUsageTotal, podEfaReservedCapacity,
88+
},
7389
"ClusterName-InstanceId-NodeName": {
7490
nodeEfaRxBytes, nodeEfaTxBytes, nodeEfaRxDropped, nodeEfaRdmaReadBytes, nodeEfaRdmaWriteBytes, nodeEfaRdmaWriteRecvBytes,
91+
nodeEfaLimit, nodeEfaUsageTotal, nodeEfaReservedCapacity, nodeEfaUnreservedCapacity, nodeEfaAvailableCapacity,
7592
},
7693
"ClusterName-InstanceId-InstanceType-NetworkInterfaceId-NodeName": {
7794
nodeEfaRxBytes, nodeEfaTxBytes, nodeEfaRxDropped, nodeEfaRdmaReadBytes, nodeEfaRdmaWriteBytes, nodeEfaRdmaWriteRecvBytes,

test/metric_value_benchmark/eks_resources/test_schemas/node_efa.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,19 @@
1919
"node_efa_rdma_write_recv_bytes": {},
2020
"node_efa_rx_bytes": {},
2121
"node_efa_rx_dropped": {},
22-
"node_efa_tx_bytes": {}
22+
"node_efa_tx_bytes": {},
23+
"node_efa_limit": {},
24+
"node_efa_usage_total": {},
25+
"node_efa_reserved_capacity": {},
26+
"node_efa_unreserved_capacity": {},
27+
"node_efa_available_capacity": {}
2328
},
2429
"required": [
2530
"ClusterName",
2631
"InstanceId",
2732
"InstanceType",
2833
"NetworkInterfaceId",
34+
"Service",
2935
"NodeName",
3036
"Timestamp",
3137
"Type",

test/metric_value_benchmark/eks_resources/test_schemas/pod_efa.json

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,27 +6,43 @@
66
"properties": {
77
"CloudWatchMetrics": {},
88
"ClusterName": {},
9+
"ContainerName": {},
10+
"FullPodName": {},
11+
"Hostname": {},
912
"InstanceId": {},
1013
"InstanceType": {},
14+
"K8sPodName": {},
15+
"Namespace": {},
1116
"NetworkInterfaceId": {},
1217
"NodeName": {},
18+
"OTelLib": {},
19+
"PodName": {},
1320
"Timestamp": {},
1421
"Type": {},
22+
"UUID": {},
1523
"Version": {},
1624
"kubernetes": {},
1725
"node_efa_rdma_read_bytes": {},
1826
"node_efa_rdma_write_bytes": {},
1927
"node_efa_rdma_write_recv_bytes": {},
2028
"node_efa_rx_bytes": {},
2129
"node_efa_rx_dropped": {},
22-
"node_efa_tx_bytes": {}
30+
"node_efa_tx_bytes": {},
31+
"pod_efa_limit": {},
32+
"pod_efa_request": {},
33+
"pod_efa_usage_total": {},
34+
"pod_efa_reserved_capacity": {}
2335
},
2436
"required": [
2537
"ClusterName",
38+
"FullPodName",
2639
"InstanceId",
2740
"InstanceType",
41+
"Namespace",
2842
"NetworkInterfaceId",
43+
"Service",
2944
"NodeName",
45+
"PodName",
3046
"Timestamp",
3147
"Type",
3248
"Version",

0 commit comments

Comments
 (0)