Telemetry emission for init stage and full process #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedloj
approved these changes
Nov 21, 2024
nborges-aws
force-pushed
the
nickdb/lspTelemetryv2
branch
from
27475ef to
8452cce
Compare
nborges-aws
force-pushed
the
nickdb/lspTelemetryv2
branch
from
8452cce to
3946d5e
Compare
shruti0085
reviewed
Nov 25, 2024
plugin/src/software/aws/toolkits/eclipse/amazonq/lsp/connection/QLspConnectionProvider.java
Show resolved
Hide resolved
shruti0085
reviewed
Nov 25, 2024
| } | ||
|
|
||
| public static void emitSetupValidate(final Result result, final RecordLspSetupArgs args) { | ||
| emitSetupMetric(result, args, LanguageServerSetupStage.VALIDATE); | ||
| if (result == Result.FAILED) { | ||
| emitSetupAll(Result.FAILED, args); |
There was a problem hiding this comment.
why not emit this at the end of the overall setup process in getlspinstallation instead of sprinkling it all across this class
There was a problem hiding this comment.
The logic here should've had and additional condition that location is not equal to override, which was fixed in PR-260. The logic is the same as this case. SetupAll should not be emitted if override fails validation, but the event should emit as telemetry wanted the granularity of knowing that override failed. This ensures that setupAll is only emitted when validation fails at a point that the entire language server setup process is halted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR includes the addition of telemetry metrics for the initialization of the amazon Q LSP server, as well as metrics for the full process of fetching and starting the LSP. Some additional QoL changes featured in this PR include:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.