Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPC CNI shouldn't reserve a ENI for trunk ENI if the instance doesn't support ENI trunking #3094

Open
haouc opened this issue Oct 30, 2024 · 3 comments

Comments

@haouc
Copy link
Contributor

haouc commented Oct 30, 2024

What would you like to be added:
Currently, VPC CNI always reserve a ENI slot for trunk ENI if the Security Group for Pods feature is enabled through its ENV ENABLE_POD_ENI. If the instance type doesn't support ENI trunking, reserving a slot in those nodes doesn't sound a correct behavior and also cause inefficient usage of ENI resources thus lower IP density. VPC CNI should be knowing not to reserve a ENI for trunk ENI if the instance type doesn't support ENI trunking.

Why is this needed:
Reserving a ENI for trunk when the instance doesn't even support ENI trunking is lowering IP density and thus pod density.

Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Issue or PR is stale label Dec 30, 2024
@innovativelife
Copy link

This issue was raised on behalf of TechnologyOne by our AWS Enterprise Support Lead, Allen Lu. We still consider this feature to be important, as not having this feature wastes resources.

@ali-parsfar
Copy link

Cloud we have an update on this feature request ?

@github-actions github-actions bot removed the stale Issue or PR is stale label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants