-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Initial architecture for AWS CLI v1-to-v2 upgrade linting tool #9803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial architecture for AWS CLI v1-to-v2 upgrade linting tool #9803
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## upgrade-linting-tool #9803 +/- ##
=======================================================
Coverage ? 93.33%
=======================================================
Files ? 209
Lines ? 16807
Branches ? 0
=======================================================
Hits ? 15687
Misses ? 1120
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hssyoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good, I like the general experience. Left a few questions and suggestions.
hssyoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small comments. Also:
- Did we add the runtime check / still plan to?
- I think we should still have a [q]uit or [a]bort option so users can exit without needing to Ctrl+C. We don't need to block this PR on it though.
hssyoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏆
Description of changes:
Description of tests:
Example output:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.