Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that decrypt will succeed for a message with MAX_FRAME_NUMBER of frames #140

Open
seebees opened this issue Nov 6, 2019 · 1 comment
Labels

Comments

@seebees
Copy link
Contributor

seebees commented Nov 6, 2019

See: https://github.com/aws/aws-encryption-sdk-java/blob/master/src/main/java/com/amazonaws/encryptionsdk/internal/FrameDecryptionHandler.java#L153

It appears that if a message has MAX_FRAME_NUMBER the decrypt will fail.

@lavaleri
Copy link
Contributor

+1

See specification at https://github.com/awslabs/aws-encryption-sdk-specification/blob/master/data-format/message-body.md#sequence-number-1
Sequence number is allowed to be the number of frames, and the number of frames includes MAX_FRAME_NUMBER

Additionally, it looks like the SDK as is will allow creating messages where MAX_FRAME_NUMBER is the last sequence number of a message, but will fail to decrypt such messages.

@lavaleri lavaleri added the bug label Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants