Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultCryptoMaterialsManager should raise an error if signer key is present in encryption context #135

Open
mattsb42-aws opened this issue Jan 4, 2019 · 2 comments
Open

DefaultCryptoMaterialsManager should raise an error if signer key is present in encryption context #135

mattsb42-aws opened this issue Jan 4, 2019 · 2 comments
Labels
bug good first issue

Comments

@mattsb42-aws
Copy link
Member

Because DefaultCryptoMaterialsManager adds a value to the encryption context if a signed algorithm suite is used, we need to throw an error if the requested encryption context already contains that key.

https://github.com/aws/aws-encryption-sdk-java/blob/eb8702e82759cca53eddc3b5f8423e74ec31aff1/src/main/java/com/amazonaws/encryptionsdk/DefaultCryptoMaterialsManager.java#L55-L58
@ttjsu-aws ttjsu-aws mentioned this issue Jan 4, 2019
Closed
4gatepylon pushed a commit to 4gatepylon/aws-encryption-sdk-python that referenced this issue Aug 7, 2019
Fixed issue aws#135. Took longer than I expected because was trying to
3256822 
get the value of the key in the encryption context dictionary to be the
same (as well as name of the key), but then learned this wasn't what
we wanted.  Wrote a test that I confirm works only after the change is
added.
@4gatepylon 4gatepylon mentioned this issue Aug 7, 2019
Closed
@4gatepylon
Copy link

Submitted PR.

#185

@acioc
Copy link

acioc commented Dec 5, 2020

Closed stale PR for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@acioc @4gatepylon @mattsb42-aws