Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential issue with large reads on nonframed messages #53

Open
mattsb42-aws opened this issue Jun 13, 2018 · 0 comments
Open

potential issue with large reads on nonframed messages #53

mattsb42-aws opened this issue Jun 13, 2018 · 0 comments
Labels

Comments

@mattsb42-aws
Copy link
Member

In tracking down an issue in an unrelated codebase, I discovered that at least in some cases, passing more than 2GiB to the pyca/cryptography Cipher.update() methods can cause issues with the underlying OpenSSL implementation.

This is not an issue with framed messages because our max frame size is 2GiB, but could be an issue for nonframed messages larger than 2GiB.

We should add tests that check for this edge case, and if it is an issue we can add chunking logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant