Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document issue for kmstool-enclave-cli #108

Open
forhead opened this issue Mar 19, 2023 · 0 comments
Open

document issue for kmstool-enclave-cli #108

forhead opened this issue Mar 19, 2023 · 0 comments

Comments

@forhead
Copy link

forhead commented Mar 19, 2023

hi
when I test the kmstool-enclave-cli, I found an issue for the README.md document, below is the link
https://github.com/aws/aws-nitro-enclaves-sdk-c/tree/main/bin/kmstool-enclave-cli

  • issue 1:

the api call example for genkey parameter is for the decrypt

proc = subprocess.Popen(
    [
        "/kmstool_enclave_cli",
        "genkey",
        "--region", "us-east-1",
        "--proxy-port", "8000",
        "--aws-access-key-id", access_key_id,
        "--aws-secret-access-key", secret_access_key,
        "--aws-session-token", token,
        "--ciphertext", ciphertext,
    ],
    stdout=subprocess.PIPE
)

result_b64 = proc.communicate()[0].decode()
plaintext_b64 = result_b64.split(":")[1].strip()
  • issue 2
    the genkey call doc says that and outputs the base64-encoded plaintext with PLAINTEXT: as prefix if the execution succeeds.
    but with my test, I get below output, it seems not clearly document for the output, can you help to clarify it?
b'CIPHERTEXT:long cipher text\nPLAINTEXT: short plain text\n'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant