From 4158878abbc4655447c83d6fc84b1d03e6859672 Mon Sep 17 00:00:00 2001 From: Nicholas Sielicki Date: Wed, 4 Sep 2024 18:54:19 -0700 Subject: [PATCH] feat(ci): add build forcing c++ mode Add a distcheck build that sets CFLAGS such that it treats all files as C++, preventing pull requests from breaking C++ compatibility going forward. stack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki --- .github/workflows/distcheck.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/distcheck.yaml b/.github/workflows/distcheck.yaml index cc44bbbff..bebaf80e7 100644 --- a/.github/workflows/distcheck.yaml +++ b/.github/workflows/distcheck.yaml @@ -95,6 +95,9 @@ jobs: sdk: - cuda - neuron + ccmode: + - c + - cpp include: - cc-variant: latest @@ -182,6 +185,11 @@ jobs: export CC="${{ matrix.realcc || matrix.cc }}" + if [ "${{ matrix.ccmode }}" == "cpp" ]; then + export CC="${CC/clang/clang++}" + export CC="${CC/gcc/g++}" + fi + # actions/checkout@v4 would drop the plugin source in $PWD, # so go ahead and build it. ./autogen.sh