Skip to content

Commit

Permalink
fix(tree): add spaces around PRIu64
Browse files Browse the repository at this point in the history
c++ requires literals not sit directly next to other literals and must
be separated by at least one whitespace token.

stack-info: PR: #555, branch: aws-nslick/stack/2
Signed-off-by: Nicholas Sielicki <[email protected]>
  • Loading branch information
aws-nslick committed Sep 4, 2024
1 parent cf0170a commit 92d7f02
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
14 changes: 7 additions & 7 deletions src/nccl_ofi_rdma.c
Original file line number Diff line number Diff line change
Expand Up @@ -2398,7 +2398,7 @@ static int dereg_mr_ep(nccl_net_ofi_rdma_mr_handle_t *mr_handle,
} else {
ret = nccl_ofi_idpool_free_id(key_pool, key);
if (OFI_UNLIKELY(ret != 0)) {
NCCL_OFI_WARN("Error freeing MR key %"PRIu64", leaking key", key);
NCCL_OFI_WARN("Error freeing MR key %" PRIu64 ", leaking key", key);
}
}
}
Expand Down Expand Up @@ -3312,7 +3312,7 @@ static int recv_close(nccl_net_ofi_recv_comm_t *recv_comm)
/* Release communicator ID */
ret = nccl_ofi_idpool_free_id(device->comm_idpool, r_comm->local_comm_id);
if (OFI_UNLIKELY(ret != 0)) {
NCCL_OFI_WARN("Error freeing communicator ID %"PRIu32"", r_comm->local_comm_id);
NCCL_OFI_WARN("Error freeing communicator ID %" PRIu32, r_comm->local_comm_id);
}

free(r_comm);
Expand Down Expand Up @@ -3690,7 +3690,7 @@ static nccl_net_ofi_rdma_recv_comm_t *prepare_recv_comm(nccl_net_ofi_rdma_device
if (~0 != r_comm->local_comm_id) {
ret = nccl_ofi_idpool_free_id(device->comm_idpool, r_comm->local_comm_id);
if (ret != 0) {
NCCL_OFI_WARN("Error freeing communicator ID %"PRIu32"", r_comm->local_comm_id);
NCCL_OFI_WARN("Error freeing communicator ID %" PRIu32, r_comm->local_comm_id);
}
}
free(r_comm);
Expand Down Expand Up @@ -4047,7 +4047,7 @@ static int listen_close(nccl_net_ofi_listen_comm_t *listen_comm)
ret = nccl_ofi_idpool_free_id(get_device_from_ep((nccl_net_ofi_rdma_ep_t *)base_ep)->comm_idpool,
l_comm->comm_id);
if (OFI_UNLIKELY(ret != 0)) {
NCCL_OFI_WARN("Error freeing communicator ID %"PRIu32"", l_comm->comm_id);
NCCL_OFI_WARN("Error freeing communicator ID %" PRIu32, l_comm->comm_id);
}

free(l_comm);
Expand Down Expand Up @@ -4125,7 +4125,7 @@ static int listen(nccl_net_ofi_ep_t *base_ep,
error:
if (l_comm && ~0 != l_comm->comm_id) {
if (0 != nccl_ofi_idpool_free_id(device->comm_idpool, l_comm->comm_id)) {
NCCL_OFI_WARN("Error freeing communicator ID %"PRIu64"", l_comm->comm_id);
NCCL_OFI_WARN("Error freeing communicator ID %" PRIu64 "", l_comm->comm_id);
}
}
free(l_comm);
Expand Down Expand Up @@ -4788,7 +4788,7 @@ static int send_close(nccl_net_ofi_send_comm_t *send_comm)
/* Release communicator ID */
ret = nccl_ofi_idpool_free_id(device->comm_idpool, s_comm->local_comm_id);
if (OFI_UNLIKELY(ret != 0)) {
NCCL_OFI_WARN("Error freeing communicator ID %"PRIu32"", s_comm->local_comm_id);
NCCL_OFI_WARN("Error freeing communicator ID %" PRIu32, s_comm->local_comm_id);
}

/* Destroy domain */
Expand Down Expand Up @@ -5076,7 +5076,7 @@ static inline int create_send_comm(nccl_net_ofi_conn_handle_t *handle,
error:
if (ret_s_comm && ~0 != ret_s_comm->local_comm_id) {
if (0 != nccl_ofi_idpool_free_id(device->comm_idpool, ret_s_comm->local_comm_id)) {
NCCL_OFI_WARN("Error freeing communicator ID %"PRIu32"", ret_s_comm->local_comm_id);
NCCL_OFI_WARN("Error freeing communicator ID %" PRIu32, ret_s_comm->local_comm_id);
}
}
free(ret_s_comm);
Expand Down
2 changes: 1 addition & 1 deletion src/nccl_ofi_sendrecv.c
Original file line number Diff line number Diff line change
Expand Up @@ -740,7 +740,7 @@ static int dereg_mr_base_comm(struct fid_mr *mr_handle,
} else {
ret = nccl_ofi_idpool_free_id(key_pool, key);
if (OFI_UNLIKELY(ret != 0)) {
NCCL_OFI_WARN("Error freeing MR key %"PRIu64", leaking key", key);
NCCL_OFI_WARN("Error freeing MR key %" PRIu64 ", leaking key", key);
}
}
}
Expand Down

0 comments on commit 92d7f02

Please sign in to comment.