From 967c953e4aac4087c83c74857074242dd9d5f836 Mon Sep 17 00:00:00 2001
From: Nicholas Sielicki <nslick@amazon.com>
Date: Thu, 22 Aug 2024 17:04:32 -0700
Subject: [PATCH] fixup! ci: add al2023 rpm builds

---
 .github/workflows/srpm.yaml | 67 +++++++++++++++++++++++++++++++++----
 1 file changed, 60 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/srpm.yaml b/.github/workflows/srpm.yaml
index 8656dc1a0..38be19673 100644
--- a/.github/workflows/srpm.yaml
+++ b/.github/workflows/srpm.yaml
@@ -2,7 +2,7 @@ name: Package Generation
 on: [push, pull_request]
 jobs:
   srpm:
-    name: Generate SRPM
+    name: "Generate SRPM"
     runs-on: ubuntu-latest
     container:
       image: fedora:rawhide
@@ -18,8 +18,12 @@ jobs:
           path: "*.src.rpm"
           if-no-files-found: 'error'
           compression-level: '0'
+
   mock-rpm:
     runs-on: ubuntu-latest
+    container:
+      image: fedora:39
+      options: --privileged --cap-add SYS_ADMIN
     needs: srpm
     strategy:
       matrix:
@@ -34,12 +38,61 @@ jobs:
             accel_repo: ""
             efa_repo: "./aws-efa-installer/RPMS/ALINUX2023/x86_64/"
             mock: "/etc/mock/amazonlinux-2023-x86_64.cfg"
-    name: [rpm] ${{ matrix.name }}
-    container:
-      image: fedora:rawhide
-      options: --privileged
+          - name: al2-x86-cuda-aws
+            args: "--define 'with_cuda 1' --define 'with_platform_aws 1'"
+            accel_repo: --addrepo "https://developer.download.nvidia.com/compute/cuda/repos/rhel7/x86_64/"
+            efa_repo: "./aws-efa-installer/RPMS/ALINUX2/x86_64/"
+            mock: "/etc/mock/amazonlinux-2-x86_64.cfg"
+          - name: al2-x86-neuron-aws
+            args: "--define 'with_neuron 1' --define 'with_platform_aws 1'"
+            accel_repo: ""
+            efa_repo: "./aws-efa-installer/RPMS/ALINUX2/x86_64/"
+            mock: "/etc/mock/amazonlinux-2-x86_64.cfg"
+          - name: rocky9-x86-neuron-aws
+            args: "--define 'with_neuron 1' --define 'with_platform_aws 1'"
+            accel_repo: ""
+            efa_repo: "./aws-efa-installer/RPMS/ROCKYLINUX9/x86_64/"
+            mock: "/etc/mock/rocky+epel-9-x86_64.cfg"
+          - name: rocky9-x86-cuda-aws
+            args: "--define 'with_neuron 1' --define 'with_platform_aws 1'"
+            accel_repo: --addrepo "https://developer.download.nvidia.com/compute/cuda/repos/rhel8/x86_64/"
+            efa_repo: "./aws-efa-installer/RPMS/ROCKYLINUX8/x86_64/"
+            mock: "/etc/mock/rocky+epel-9-x86_64.cfg"
+          - name: rocky8-x86-neuron-aws
+            args: "--define 'with_neuron 1' --define 'with_platform_aws 1'"
+            accel_repo: ""
+            efa_repo: "./aws-efa-installer/RPMS/ROCKYLINUX8/x86_64/"
+            mock: "/etc/mock/rocky-8-x86_64.cfg"
+          - name: rocky8-x86-cuda-aws
+            args: "--define 'with_neuron 1' --define 'with_platform_aws 1'"
+            accel_repo: --addrepo "https://developer.download.nvidia.com/compute/cuda/repos/rhel8/x86_64/"
+            efa_repo: "./aws-efa-installer/RPMS/ROCKYLINUX8/x86_64/"
+            mock: "/etc/mock/rocky-8-x86_64.cfg"
+          - name: leap155-x86-neuron-aws
+            args: "--define 'with_neuron 1' --define 'with_platform_aws 1'"
+            accel_repo: ""
+            efa_repo: "./aws-efa-installer/RPMS/SUSE/x86_64/"
+            mock: "/etc/mock/opensuse-leap-15.5-x86_64.cfg"
+          - name: leap155-x86-cuda-aws
+            args: "--define 'with_neuron 1' --define 'with_platform_aws 1'"
+            accel_repo: --addrepo "https://developer.download.nvidia.com/compute/cuda/repos/opensuse15/x86_64/"
+            efa_repo: "./aws-efa-installer/RPMS/SUSE/x86_64/"
+            mock: "/etc/mock/opensuse-leap-15.5-x86_64.cfg"
+          ## need to figure out binfmt_misc registration under gh actions for these to work.
+          # - name: rocky9-aarch64-neuron-aws
+          #   args: "--define 'with_neuron 1' --define 'with_platform_aws 1'"
+          #   accel_repo: ""
+          #   efa_repo: "./aws-efa-installer/RPMS/ROCKYLINUX9/aarch64/"
+          #   mock: "/etc/mock/rocky+epel-9-aarch64.cfg"
+          # - name: rocky9-aarch64-cuda-aws
+          #   args: "--define 'with_neuron 1' --define 'with_platform_aws 1'"
+          #   accel_repo: --addrepo "https://developer.download.nvidia.com/compute/cuda/repos/rhel9/aarch64/"
+          #   efa_repo: "./aws-efa-installer/RPMS/ROCKYLINUX9/aarch64/"
+          #   mock: "/etc/mock/rocky+epel-9-aarch64.cfg"
+
+    name: Build RPM for ${{ matrix.name }}
     steps:
-      - run: dnf install -y mock nodejs unzip curl createrepo_c
+      - run: dnf install -y mock nodejs createrepo_c
       - uses: actions/download-artifact@master
         with:
           name: "libnccl-net-ofi.src.rpm"
@@ -47,7 +100,7 @@ jobs:
       - run: curl -O https://efa-installer.amazonaws.com/aws-efa-installer-latest.tar.gz
       - run: tar xf ./aws-efa-installer-latest.tar.gz
       - run: bash -c "cd ${{ matrix.efa_repo }} && createrepo_c ."
-      - run: mock --verbose --addrepo $(realpath ${{ matrix.efa_repo }}) ${{ matrix.accel_repo }} -r ${{ matrix.mock }} ${{ matrix.args }} *.src.rpm
+      - run: mock --isolation=simple --verbose --addrepo file://$(realpath ${{ matrix.efa_repo }}) ${{ matrix.accel_repo }} -r ${{ matrix.mock }} ${{ matrix.args }} *.src.rpm
       - run: rpm -qpl /var/lib/mock/**/result/*.rpm
       #- uses: actions/upload-artifact@v4
       #  with: