nit: deque: avoid typedef hell #561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-nslick
force-pushed
the
aws-nslick/stack/7
branch
from
07d8b1c to
ffbace2
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/8
branch
from
16bcbc1 to
bdcd2f1
Compare
This was referenced Sep 4, 2024
the canonical token is __cplusplus not _cplusplus. When this is incorrect, linkage fails as cxx will perform name mangling when including these headers, resulting in a function with that mangle not existing. stack-info: PR: #554, branch: aws-nslick/stack/1 Signed-off-by: Nicholas Sielicki <[email protected]>
c++ requires literals not sit directly next to other literals and must be separated by at least one whitespace token. stack-info: PR: #555, branch: aws-nslick/stack/2 Signed-off-by: Nicholas Sielicki <[email protected]>
stack-info: PR: #556, branch: aws-nslick/stack/3 Signed-off-by: Nicholas Sielicki <[email protected]>
When using designated initializer lists, under C++ only, a warning will be emitted if the declaration order does not match the initialization order if any fields are missing in the initializer list. Reorder these structs to initialize all fields in their declaration order. stack-info: PR: #557, branch: aws-nslick/stack/4 Signed-off-by: Nicholas Sielicki <[email protected]>
void pointer arithmetic is illegal in c++; cast to uintptr, do the offset, then cast to void* to pass to libfabric. stack-info: PR: #558, branch: aws-nslick/stack/5 Signed-off-by: Nicholas Sielicki <[email protected]>
stack-info: PR: #559, branch: aws-nslick/stack/6 Signed-off-by: Nicholas Sielicki <[email protected]>
bwbarrett
requested changes
Sep 4, 2024
| @@ -23,21 +23,20 @@ extern "C" { | |||
| * this structure as a black box. Critically, the caller must ensure the | |||
There was a problem hiding this comment.
My comment in 52a6994#r1714461159 needs to be addressed.
stack-info: PR: #560, branch: aws-nslick/stack/7 Signed-off-by: Nicholas Sielicki <[email protected]>
Prefer to define the structures in vanilla C without relying on any custom typedefs, and move the typedef to the bottom of the file for consumers to use, if they want. stack-info: PR: #561, branch: aws-nslick/stack/8 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
force-pushed
the
aws-nslick/stack/8
branch
from
bdcd2f1 to
ad657de
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/7
branch
from
74856f4 to
36d93ae
Compare
|
Abandoning this as the build works without it, and it is contentious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
nit: deque: avoid typedef hell
Prefer to define the structures in vanilla C without relying on any
custom typedefs, and move the typedef to the bottom of the file for
consumers to use, if they want.
Signed-off-by: Nicholas Sielicki [email protected]