-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): mpi: set mpicxx, too. #567
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-nslick
force-pushed
the
aws-nslick/stack/14
branch
from
September 4, 2024 16:45
eb30146
to
f071592
Compare
This was referenced Sep 4, 2024
aws-nslick
force-pushed
the
aws-nslick/stack/14
branch
from
September 4, 2024 19:07
f071592
to
89cda52
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/14
branch
from
September 4, 2024 19:16
89cda52
to
63cffe6
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/14
branch
from
September 4, 2024 20:25
63cffe6
to
e090c1e
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/14
branch
from
September 4, 2024 20:25
e090c1e
to
1c3b4b3
Compare
This was referenced Sep 4, 2024
Merged
This was referenced Sep 12, 2024
aws-nslick
force-pushed
the
aws-nslick/stack/14
branch
from
September 12, 2024 01:10
760a512
to
be3256a
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/14
branch
from
September 12, 2024 01:51
be3256a
to
e0fb02b
Compare
rauteric
previously approved these changes
Sep 13, 2024
aws-nslick
force-pushed
the
aws-nslick/stack/14
branch
from
September 13, 2024 17:49
e0fb02b
to
68343c0
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/14
branch
from
September 14, 2024 22:37
68343c0
to
3c7c321
Compare
stack-info: PR: #567, branch: aws-nslick/stack/14 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
force-pushed
the
aws-nslick/stack/14
branch
from
September 17, 2024 20:25
3c7c321
to
d8a1b66
Compare
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 22, 2024
stack-info: PR: aws#567, branch: aws-nslick/stack/14 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 22, 2024
stack-info: PR: aws#567, branch: aws-nslick/stack/14 Signed-off-by: Nicholas Sielicki <[email protected]>
bwbarrett
approved these changes
Sep 24, 2024
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 25, 2024
stack-info: PR: aws#567, branch: aws-nslick/stack/14 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 25, 2024
stack-info: PR: aws#567, branch: aws-nslick/stack/14 Signed-off-by: Nicholas Sielicki <[email protected]>
Squashed this into #568 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
chore(build): mpi: set mpicxx, too.
Signed-off-by: Nicholas Sielicki [email protected]