Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rdma): use COMM_ID_MASK as invalid id #574

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix(rdma): use COMM_ID_MASK as invalid id #574

merged 1 commit into from
Sep 27, 2024

Conversation

aws-nslick
Copy link
Contributor

@aws-nslick aws-nslick commented Sep 4, 2024 •
edited
Loading

Stacked PRs:

fix(rdma): use COMM_ID_MASK as invalid id

Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_MASK as the marker.
Signed-off-by: Nicholas Sielicki [email protected]

@aws-nslick aws-nslick requested a review from a team as a code owner September 4, 2024 20:25
This was referenced Sep 4, 2024
Merged
Merged
Closed
Closed
Merged
Merged
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/20 to master September 4, 2024 20:58
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/22 September 4, 2024 20:59
This was referenced Sep 4, 2024
Merged
Merged
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/22 to master September 5, 2024 01:17
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/22 September 5, 2024 01:18
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/22 to master September 5, 2024 01:44
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/22 September 5, 2024 01:45
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/22 to master September 5, 2024 01:56
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/22 September 5, 2024 01:56
@aws-nslick aws-nslick mentioned this pull request Sep 5, 2024
Closed
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/22 to master September 5, 2024 02:03
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/22 September 5, 2024 02:03
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/22 to master September 5, 2024 02:08
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/22 September 14, 2024 22:37
@aws-nslick
fix(rdma): use COMM_ID_MASK as invalid id
a06ae92 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_MASK as the marker.

stack-info: PR: #574, branch: aws-nslick/stack/21
Signed-off-by: Nicholas Sielicki <[email protected]>
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/22 to master September 17, 2024 20:25
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/22 September 17, 2024 20:26
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 22, 2024
@aws-nslick
fix(rdma): use COMM_ID_MASK as invalid id
3e0fdf2 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_MASK as the marker.

stack-info: PR: aws#574, branch: aws-nslick/stack/21
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 22, 2024
@aws-nslick
fix(rdma): use COMM_ID_MASK as invalid id
10bbd0b 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_MASK as the marker.

stack-info: PR: aws#574, branch: aws-nslick/stack/21
Signed-off-by: Nicholas Sielicki <[email protected]>
bwbarrett
bwbarrett approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@bwbarrett bwbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have added a COMM_ID_INVALID that might be the same as COMM_ID_MASK but reduces cognitive load, but this works.

aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 25, 2024
@aws-nslick
fix(rdma): use COMM_ID_MASK as invalid id
150e05e 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_MASK as the marker.

stack-info: PR: aws#574, branch: aws-nslick/stack/21
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 25, 2024
@aws-nslick
fix(rdma): use COMM_ID_MASK as invalid id
82caf53 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_MASK as the marker.

stack-info: PR: aws#574, branch: aws-nslick/stack/21
Signed-off-by: Nicholas Sielicki <[email protected]>
@aws-nslick
Copy link
Contributor Author

I would have added a COMM_ID_INVALID that might be the same as COMM_ID_MASK but reduces cognitive load, but this works.

That is better, I agree. Have made this change locally and will be reposted.

aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 26, 2024
@aws-nslick
fix(rdma): define COMM_ID_INVALID
c6bd1dc 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_INVALID (defined as COMM_ID_MASK) as the marker.

stack-info: PR: aws#574, branch: aws-nslick/stack/21
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 26, 2024
@aws-nslick
fix(rdma): define COMM_ID_INVALID
20beed0 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_INVALID (defined as COMM_ID_MASK) as the marker.

stack-info: PR: aws#574, branch: aws-nslick/stack/21
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 26, 2024
@aws-nslick
fix(rdma): define COMM_ID_INVALID (aws#574)
16ae8e5 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_INVALID (defined as COMM_ID_MASK) as the marker.

Signed-off-by: Nicholas Sielicki <[email protected]>
@aws-nslick aws-nslick merged commit e65daf3 into aws-nslick/stack/22 Sep 27, 2024
32 of 33 checks passed
@aws-nslick aws-nslick mentioned this pull request Sep 27, 2024
Merged
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 27, 2024
@aws-nslick
fix(rdma): define COMM_ID_INVALID (aws#574)
a2b26df 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_INVALID (defined as COMM_ID_MASK) as the marker.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 27, 2024
@aws-nslick
fix(rdma): define COMM_ID_INVALID (aws#574)
6e60df6 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_INVALID (defined as COMM_ID_MASK) as the marker.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 27, 2024
@aws-nslick
fix(rdma): define COMM_ID_INVALID (aws#574)
115d564 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_INVALID (defined as COMM_ID_MASK) as the marker.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 27, 2024
@aws-nslick
fix(rdma): define COMM_ID_INVALID (aws#574)
063e5a0 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_INVALID (defined as COMM_ID_MASK) as the marker.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 28, 2024
@aws-nslick
fix(rdma): define COMM_ID_INVALID (aws#574)
1ecfffb 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_INVALID (defined as COMM_ID_MASK) as the marker.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 28, 2024
@aws-nslick
fix(rdma): define COMM_ID_INVALID (aws#574)
db51f19 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_INVALID (defined as COMM_ID_MASK) as the marker.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
fix(rdma): define COMM_ID_INVALID (aws#574)
a0269a1 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_INVALID (defined as COMM_ID_MASK) as the marker.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
fix(rdma): define COMM_ID_INVALID (aws#574)
f8c4eda 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_INVALID (defined as COMM_ID_MASK) as the marker.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
fix(rdma): define COMM_ID_INVALID (aws#574)
2623dd8 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_INVALID (defined as COMM_ID_MASK) as the marker.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
fix(rdma): define COMM_ID_INVALID (aws#574)
684bbcb 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_INVALID (defined as COMM_ID_MASK) as the marker.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
fix(rdma): define COMM_ID_INVALID (aws#574)
d55b0fd 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_INVALID (defined as COMM_ID_MASK) as the marker.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 1, 2024
@aws-nslick
fix(rdma): define COMM_ID_INVALID (aws#574)
a50bd84 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_INVALID (defined as COMM_ID_MASK) as the marker.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit that referenced this pull request Oct 1, 2024
@aws-nslick
fix(rdma): define COMM_ID_INVALID (#574)
50c8d07 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_INVALID (defined as COMM_ID_MASK) as the marker.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-ofiwg-bot pushed a commit to aws-ofiwg-bot/aws-ofi-nccl that referenced this pull request Oct 4, 2024
@aws-nslick @aws-ofiwg-bot
fix(rdma): define COMM_ID_INVALID (aws#574)
1dc69c8 
Previously, this used ~0 as the invalid signal. This defaults to a
signed type, which breaks under -wsign-compare. Prefer to use
COMM_ID_INVALID (defined as COMM_ID_MASK) as the marker.

Signed-off-by: Nicholas Sielicki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwbarrett bwbarrett bwbarrett approved these changes

@rajachan rajachan Awaiting requested review from rajachan

@rauteric rauteric Awaiting requested review from rauteric

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aws-nslick @bwbarrett